ci(release): reduce permissions, avoid persisting credentials#20
Merged
ci(release): reduce permissions, avoid persisting credentials#20
Conversation
![ai-coding-guardrails[bot]](https://avatars.githubusercontent.com/in/1202546?s=60&v=4){kind=small}
There was a problem hiding this comment.
I've got 1 comment for you to consider
Reviewed with 🤟 by Zenable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor Comments
This reduces the permissions of the
GITHUB_TOKENwhen running a release on a generated project (it no longer asks for PR: write permissions), and it also doesn't persistgitcreds, which is the default foractions/checkout@v4I manually tested this in a project I generated and saw that it was still able to make a relase.
Pull Request Checklist
Thank you for submitting a contribution!
Please address the following items: