Development #38
Merged
Development #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated order and checkout creation to include currency as a parameter. - Implemented functions to set, remove, and retrieve variant prices in multiple currencies. - Enhanced product variant entity to manage prices in different currencies. - Modified API handlers to support new currency-related endpoints for variant price management. - Updated DTOs to include currency information for checkout and product variant responses. - Added validation for currency and price inputs across relevant use cases and handlers.
- Updated order processing to use order-specific currency instead of default currency. - Modified payment services to accept currency as a parameter for refunds, captures, and cancellations. - Enhanced checkout and order use cases to handle currency correctly. - Added currency field to the Order entity and updated related database migrations. - Adjusted payment service interfaces and implementations for consistency with currency handling. - Updated mock payment service to simulate currency behavior. - Refactored checkout handler to streamline order creation from checkout sessions.
…s in ListResponseDTO
…irectly and improve unauthorized access handling in order handler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes across the codebase to enhance multi-currency support, streamline Docker commands, and improve test coverage. The most significant updates include refactoring currency handling in the checkout and payment processes, updating Docker commands for compatibility, and modifying database configurations. Below is a categorized summary of the most important changes:
Multi-Currency Enhancements:
ProcessPaymentininternal/application/usecase/checkout_usecase.goto use the order's currency instead of the default currency for payment validation and processing. This ensures accurate currency handling throughout the payment flow. [1] [2] [3] [4] [5]getPriceInCurrencymethod ininternal/application/usecase/checkout_usecase.goto dynamically retrieve or convert variant prices based on the checkout's currency.GetOrCreateCheckoutBySessionIDWithCurrencyininternal/application/usecase/checkout_usecase.goto allow creating checkouts with a specified currency, including validation of enabled currencies.internal/application/usecase/discount_usecase_test.goto include currency information in order creation, ensuring multi-currency compatibility in discount logic. [1] [2] [3] [4] [5] [6]Docker Command Updates:
Makefileto replacedocker-composecommands withdocker composefor compatibility with newer Docker versions. This change applies to database operations (db-start,db-stop, etc.) and application stack commands (run-docker,stop-docker). [1] [2]Database Configuration:
commercifytocommercifydbindocker-compose.ymlto align with updated naming conventions. [1] [2]Postman Test Adjustments:
docs/commercify_checkout_postman_tests.jsonto remove the "+" prefix from phone numbers, ensuring consistency in test data formatting. [1] [2]API Documentation Updates:
docs/product_api_examples.mdto include detailed examples for setting, retrieving, and removing multi-currency variant prices, along with benefits and use cases for multi-currency pricing.