Cleanup whole lotta shit #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated PaymentTransaction to allow multiple transactions per order type, enhancing support for partial captures and retries.
- Changed Metadata field in PaymentTransaction from common.StringMap to gorm.io/datatypes.JSONMap for better JSON handling.
- Modified Product entity to use gorm.io/datatypes.JSONSlice for Images, replacing common.StringSlice.
- Refactored ProductVariant to utilize gorm.io/datatypes for Attributes and Images, improving JSON storage.
- Implemented CreateOrUpdate method in PaymentTransactionRepository for upsert behavior, ensuring only one transaction per type per order.
- Updated payment provider service to accept map[string]interface{} for configuration, replacing common.JSONB.
- Enhanced repository methods to support JSON queries in a database-agnostic manner.
- Removed unused VariantAttributes struct and its associated methods from ProductVariant.
- Updated tests to reflect changes in transaction handling and repository methods.
…saction repository, and product repository - Deleted the mock PaymentProviderService implementation used for testing payment provider functionalities. - Removed the mock PaymentTransactionRepository implementation that handled payment transaction operations. - Eliminated the mock ProductRepository implementation responsible for product management in tests.
…der methods handling
… tracking - Added idempotency key handling in MobilePay webhook events to prevent duplicate transactions. - Implemented checks for existing transactions before recording new ones for authorization, capture, cancellation, expiration, and refund events. - Introduced new tests for idempotency logic in MobilePay webhook handler. - Enhanced transaction amount tracking in tests, ensuring accurate sums for authorized, captured, and refunded amounts. - Updated Stripe webhook handler to include a placeholder for idempotency key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several updates across multiple files to improve functionality, simplify code, and remove redundant logic. Key changes include removing the
MOBILEPAY_MARKETconfiguration, refactoring JSON-based methods for setting addresses and discounts, adding support for partial refunds, and introducing error handling for checkout and order creation processes.Configuration Changes:
MOBILEPAY_MARKETfromMobilePayConfigand.env.example, simplifying MobilePay settings. [1] [2] [3]Refactoring JSON-based Methods:
SetShippingAddressJSON,SetBillingAddressJSON) with direct methods (SetShippingAddress,SetBillingAddress) incmd/seed/main.gofor orders and checkouts. [1] [2] [3]Payment Processing Enhancements:
Error Handling Improvements:
CreateOrderFromCheckoutby validating checkout conversion and handling errors during order creation.RemoveDiscountFromOrder.Dependency Updates:
filippo.io/edwards25519,gorm.io/datatypes,gorm.io/driver/mysql) togo.modfor enhanced functionality. [1] [2]