feat: Enhance UpdateCategory to handle ParentID logic #52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces changes to the category update functionality, focusing on handling the
ParentIDfield, ensuring proper database updates, and adding comprehensive tests. The most important changes include modifying the logic to handleParentIDasnilwhen set to0, improving database update behavior forParentID, and adding tests to validate these behaviors.Changes to
ParentIDhandling:internal/application/usecase/category_usecase.go: UpdatedUpdateCategorylogic to interpretParentIDasnilwhen set to0, ensuring proper removal of parent associations. Added validation to prevent circular references and refetch updated categories to maintain data integrity. [1] [2] [3] [4]Database update improvements:
internal/infrastructure/repository/gorm/category_repository.go: Modified theUpdatemethod to use explicit field updates (name,description,parent_id) to ensureParentIDis correctly updated when set tonil.internal/infrastructure/repository/gorm/category_repository.go: Changed theDeletemethod to useUnscopeddeletes, ensuring soft-deleted categories are removed completely.Test additions:
internal/application/usecase/category_usecase_test.go: Added a test caseTestCategoryUseCase_UpdateCategory_ParentIDZeroto verify that settingParentIDto0removes the parent association.internal/infrastructure/repository/gorm/category_repository_test.go: Added multiple test cases to validateParentIDupdates, including transitions fromnilto valid IDs, valid IDs tonil, and switching between valid IDs.