refactoring - protected #84
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 🎨 Move sources into packages folder * 🚨 Link packages and fix linting * 🔥 Remove examples site and fresh install one with create-react-app * 🔨 Remove empty line * 💚 Fix ci script * 🔥 Remove default content * 🔧 Remove non-existent option on lerna bootstrap * 🔧 Add start script for examples in root package.json * 🔨 Set right package and version in hoc-react-loader-examples * 🔨 Remove tab characters * 👌 Use scope instead of ignore option * 🎨 Move LICENSE and README.md to root level
Member
Author
|
@frinyvonnick can you take care of removing comment from a squash commit to avoid this please ? |
Member
Author
|
I will remove this description when this PR will be ready to |
Collaborator
|
Sure i can 👍 |
Member
Author
|
@frinyvonnick FYI So I move back to npm for that client ;) edit:
|
Collaborator
|
Maybe we can close this PR ? |
Member
Author
|
Yeah, sorry about this :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #83 - Related issue
fixes #34 - Documentation
fixes #32 - Documentation
fixes #81 - Hot reload in examples
Before merge
git rebase -i master)git rebase -i master), take care to set the right author withgit commit --amend --authorgit commit --amend --author 'Fabien JUIF <fabien.juif@gmail.com>'