✨ delay parameter #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabienjuif
reviewed
Jan 5, 2018
src/core.jsx
Outdated
| componentDidMount() { | ||
| // set delay | ||
| if (delay) { | ||
| setTimeout(() => this.setState(state => ({ ...state, pastDelay: true })), delay) |
Member
There was a problem hiding this comment.
you should register the timer and clear it in componentWillUnmount
this.timer = setTimeout()...
fabienjuif
reviewed
Jan 5, 2018
src/core.jsx
Outdated
|
|
||
| state = { | ||
| props: {}, | ||
| pastDelay: false, |
Member
There was a problem hiding this comment.
- use
printfield instead ofpastDelay - init it to
true - in the
rendermethod you can simplify the condition :if (!this.state.print) return null
Collaborator
Author
|
@fabienjuif it's done you can check it |
Collaborator
Author
|
I should add some documentation in the readme file |
Member
|
The code is fine, I'm waiting for the documentation :) |
Collaborator
|
You should probably reference the issue as well =) |
fabienjuif
reviewed
Jan 6, 2018
README.md
Outdated
|
|
||
| When a component loads very quickly, you will see a flash of the loading component. | ||
| To avoid this behaviour, you can add a `delay` parameter to the loader with a time in milliseconds. | ||
| Then, the loading indicator will be rendered, only after this delay (of course, if the component is loaded before, then it will be rendered) |
Member
There was a problem hiding this comment.
To much ponctuation for me.
Something like that maybe ?
Then, the loading indicator will be rendered after the delay if the Component can't be rendered before that.
fabienjuif
reviewed
Jan 6, 2018
README.md
Outdated
| export default loader({ print: ['data'], delay: 200 })(MyComponent) | ||
| ``` | ||
|
|
||
| By default, the no delay is defined. |
Member
There was a problem hiding this comment.
By default, no delay is defined. ?
Member
|
from @ptitFicus comment, I added the reference to the issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #67
TODO: