Skip to content

Conversation

@MailyLehoux
Copy link
Contributor

@MailyLehoux MailyLehoux commented Sep 20, 2022

fix #187
fix #224

@MailyLehoux
Copy link
Contributor Author

According to the message of Julien Landuré (https://zenika.slack.com/archives/C021ASG3K8V/p1660657892218849) on the Skillz Slack. I purpose something like that :
Capture d’écran de 2022-09-20 18-20-46

And then when the mouse is hover a circle :
Capture d’écran du 2022-09-20 18-22-11

This app inspired me. And I think, it's a good idea to remove all the skills name that have the same note. Cause, if the user have too much skills, the circles can overlap, and we wouldn't see anythin

Please tell me what do you think @StephanieHP @benjaminbrgs

@bengeois
Copy link
Member

I agree with that. It's really better like this 👍🏼

I was thinking about having a modal when you click on the circle instead of zooming ? In this way, we could improve the readability of the skills (in a list for example).

Your solution is ok for me, mine is just a thinking and could be lead to too many modal.

@MailyLehoux
Copy link
Contributor Author

Thanks @benjaminbrgs for the fix of the bigger circles 💯

I'll just fix something that I've missed :
Capture d’écran de 2022-09-21 14-59-13

It's showing the lenght on the home radar, but it should display the labels

@MailyLehoux MailyLehoux merged commit 48f1c4c into main Sep 21, 2022
@MailyLehoux MailyLehoux deleted the feat/zoom_circles branch September 21, 2022 13:05
@bengeois bengeois changed the title [WIP] 🚧 circles in skills graph 🚧 circles in skills graph Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

circles on skills radar are broken when we have to much skills Not able to see all the competencies in the graph

3 participants