Conversation
Collaborator
Author
|
Heating management class works as intended now, just the tuning of the controller/ temperature setpoints can be improved in the future, to get a bit smoother control during temperature setpoint switches. But, for now merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Off peak heatpump management added to the engine, interval can be set to prevent a heatpump from heating during that interval. Before the interval, the management determines how warm the house must be to be able to bridge the 'no heating interval' comfortably (within the set comfort limits).
-> Works as intended, except for: For some reason the interval does not start at the set deadline, but one hour earlier. Find out why, and fix!
J_Heatingpreferences class added that contains all the heating preferences of the 'users of the GC'. Things like start day time termperature, but also max min comfort limits that can be used for certain heating managements. It is part of the J_HeatingManagement interface for now. Where a getter and a setter has been added. That can be used to pass the preferences on to a newly set heating management after slider changes etc.
-> Heating preferences are completely finished. J_HeatingManagementHeatpumpOffPeak almost, just need to find the bug/reason still that influences the interval start time. Could merge already, as the interface loader and other projects dont use this OffPeak heatingmanagement class yet, but probably better to just wait a bit till the interval error is found.