-
-
Notifications
You must be signed in to change notification settings - Fork 464
Added Drawing app in Javascript #282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Astrodevil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't have to create folder inside public. Please follow the proper file order of this repository. filename should not v default(index,style,script) Css and js must be in assets folder. Change every linkage accordingly.
| - *Why clone everything to the machine? Just press "." (dot) after opening the forked repo in a browser tab. See the Magic!π* | ||
| - *Want to preview your live changes? Copy and paste the project.html URL into [GitHack](https://raw.githack.com/). You will get 2 URLs for production and development, copy and paste them into a new tab. See the Magic!π* | ||
|
|
||
| <br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't have to make changes in README. It's not needed, I closed your issue related to this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You must review it again it's not the change made by me in the readme, it's reflected in my PR because I merged it with the updated branch of yours, also being active in the world of open source I would like to suggest that the hierarchy that you are following in your project is not professional and globally accepted.
Hope this helps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion about file hierarchy, will revamp it after GSSoC.
|
Thank you @pranjay-poddar for taking out your valuable time in order to contribute to our project. Looking forward for more such amazing contributions :) |
Added drawing app
π οΈ Fixes Issue #219
π¨βπ» Changes proposed
β Check List (Check all the applicable boxes)
π Note to reviewers
π· Screenshots
Added in Homepage