Skip to content

Conversation

@pranjay-poddar
Copy link
Member

Added drawing app

πŸ› οΈ Fixes Issue #219

πŸ‘¨β€πŸ’» Changes proposed

βœ… Check List (Check all the applicable boxes)

  • My code doesn't break any part of the project (Zero Octave-Javascript-Projects).
  • This PR does not contain plagiarized content.
  • My Addition/Changes works properly and matches the overall repo pattern.
  • The title of my pull request is a short description of the requested changes.

πŸ“„ Note to reviewers

πŸ“· Screenshots

Drawing-app

Added in Homepage

image

@pranjay-poddar pranjay-poddar changed the title Added Drawing app Added Drawing app in Javascript Mar 5, 2022
@Astrodevil Astrodevil linked an issue Mar 5, 2022 that may be closed by this pull request
7 tasks
Copy link
Member

@Astrodevil Astrodevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't have to create folder inside public. Please follow the proper file order of this repository. filename should not v default(index,style,script) Css and js must be in assets folder. Change every linkage accordingly.

- *Why clone everything to the machine? Just press "." (dot) after opening the forked repo in a browser tab. See the Magic!πŸŽ‰*
- *Want to preview your live changes? Copy and paste the project.html URL into [GitHack](https://raw.githack.com/). You will get 2 URLs for production and development, copy and paste them into a new tab. See the Magic!πŸŽ‰*

<br>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't have to make changes in README. It's not needed, I closed your issue related to this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You must review it again it's not the change made by me in the readme, it's reflected in my PR because I merged it with the updated branch of yours, also being active in the world of open source I would like to suggest that the hierarchy that you are following in your project is not professional and globally accepted.

Hope this helps.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion about file hierarchy, will revamp it after GSSoC.

@github-actions
Copy link

github-actions bot commented Mar 7, 2022

Thank you @pranjay-poddar for taking out your valuable time in order to contribute to our project. Looking forward for more such amazing contributions :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drawing App In javascript

2 participants