Skip to content

[Refactor] OAuth 2.0 #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jan 31, 2025
Merged

[Refactor] OAuth 2.0 #34

merged 11 commits into from
Jan 31, 2025

Conversation

@Zerohertz
Copy link
Owner

@Zerohertz Zerohertz commented Jan 31, 2025 •
edited
Loading

What type of PR is this?

  • feat
  • fix
  • refactor
  • test
  • infra
  • ci/cd
  • docs
  • chore

What this PR does / why we need it

fastapi-cookbook/app/schemas/auth.py

Lines 19 to 29 in d52550d

class PasswordOAuthRequest(OAuthRequest):
grant_type: Annotated[str, Form(pattern="password")]
username: Annotated[
str,
Form(
min_length=5,
max_length=50,
pattern=r"^[a-zA-Z0-9_.+-]+@[a-zA-Z0-9-]+\.[a-zA-Z0-9-.]+$",
),
]
password: Annotated[str, Form(min_length=8, max_length=30)]

  • Swagger UI 내에서 OAuth를 바로 사용할 수 있도록 기능 추가 (resolves: [Feat] Swagger UI에서 OAuth 2.0 수행 #33)
  • Swagger UI의 customizing을 위한 swagger-ui-bundle.js 및 swagger-ui.css 추가
  • BaseResponse인 경우에만 APIResponse를 return 하도록 변경
  • 변경점에 따른 test code 추가

@Zerohertz Zerohertz self-assigned this Jan 31, 2025
@Zerohertz Zerohertz merged commit 2e3a522 into main Jan 31, 2025
23 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Zerohertz Zerohertz

Labels

bug 🐛 refactor ♻️ test 🧪

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feat] Swagger UI에서 OAuth 2.0 수행 [Refactor] OAuth 2.0

2 participants

@Zerohertz