Merge main and quadratic SFRD

[JulianBMunoz]

No description provided.

[Copilot]

Pull request overview

This PR merges changes related to the “quadratic SFRD” work into main, updating the SFR efficiency calculation and annotating new edit provenance in the SFRD module.

Changes:

• Add an additional editor attribution block in zeus21/sfrd.py.
• Modify fstarofz to clip the (pre-baryon-fraction) star-formation efficiency to [0, 1], effectively capping returned fstar at OmegaB/OmegaM.

Comments suppressed due to low confidence (2)

zeus21/sfrd.py:690

• fstarofz now hard-caps the pre-baryon-fraction efficiency to 1.0 via np.clip(..., 0, 1), which implies the returned fstar is capped at OmegaB/OmegaM regardless of Astro_Parameters.fstarmax (except when fstarmax < OmegaB/OmegaM). If fstarmax is intended to be the sole user-controlled cap, consider clipping using Astro_Parameters.fstarmax (or documenting that fstar is now physically limited to OmegaB/OmegaM), and consider whether the PopIII path (fstarofz_III) should be capped the same way for consistency.

        self.xHI_avg = (1.0 - self._xHII_avg)
        self.xHI_avg = np.fmin(1.0, self.xHI_avg)
        
        

zeus21/sfrd.py:688

• The new clipping behavior in fstarofz is a functional change (it saturates at OmegaB/OmegaM). There are tests for SFR behavior in tests/test_astrophysics.py, but nothing directly asserts the new saturation/positivity behavior of fstarofz. Adding a small unit test that exercises extreme epsstar/mass values and asserts 0 <= fstarofz <= OmegaB/OmegaM would help prevent accidental regressions (and clarify intended behavior).

        self.xHI_avg = (1.0 - self._xHII_avg)
        self.xHI_avg = np.fmin(1.0, self.xHI_avg)

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.