CYW43xx driver - part 1 #489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grazfather
reviewed
Apr 22, 2025
Collaborator
Grazfather
left a comment
Grazfather
left a comment
There was a problem hiding this comment.
Awesome! Just gave it a quick read for now, some style comments.
Will have to deep dive later.
Grazfather
reviewed
Apr 22, 2025
Grazfather
reviewed
Apr 22, 2025
Grazfather
reviewed
Apr 22, 2025
Grazfather
reviewed
Apr 22, 2025
Grazfather
reviewed
Apr 22, 2025
Grazfather
reviewed
Apr 22, 2025
Grazfather
reviewed
Apr 23, 2025
Grazfather
reviewed
Apr 25, 2025
Collaborator
Grazfather
left a comment
Grazfather
left a comment
There was a problem hiding this comment.
Some more formatting nit picks, looks good to me, Q about the logging (we can keep, but we should not keep debug level for most examples in that case).
Hoping for a second set of eyes on it.
mattnite
approved these changes
Apr 25, 2025
tact1m4n3
approved these changes
Apr 25, 2025
…rozig into cyw43_part_1
tact1m4n3
reviewed
Apr 25, 2025
Collaborator
|
I tested it on rp2350 and it works fine. Great patch! |
auto-merge was automatically disabled
April 25, 2025 17:42
Head branch was pushed to by a user without write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces CYW43xx WiFi driver. Right now entire booting seqence + firmware upload. This code is based on embassy project: https://github.com/embassy-rs/embassy/tree/main/cyw43