Skip to content

Conversation

@Uthedris
Copy link
Contributor

This adds the missing RP2040 atomic external definitions to support Zig's @atomicLoad, @atomicRmw, @aromicStore, @cmpxchgStrong and @cmpxchgWeak. operations.

@arkadiuszwojcik
Copy link
Contributor

@Uthedris so _ = @import("hal/atomic.zig"); from hal.zig can be removed right now? I had to use it so conditional comptime export would work. Now chip check in that file is removes so maybe this line is not required?

@Uthedris
Copy link
Contributor Author

Uthedris commented May 15, 2025

@arkadiuszwojcik the guard against being in test mode still seems to be required. When I removed it, I could build my program that used atomics just fine, but the GitHub test suite failed the Unit Test Ports tests.

@mattnite mattnite merged commit c7434ee into ZigEmbeddedGroup:main May 15, 2025
43 checks passed
@Uthedris Uthedris deleted the rp2xxx_atomics branch May 15, 2025 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants