Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🔍 Lint Results
ℹ️ Additional issues on unchanged lines
The following 8 issue(s) exist but are not on lines changed in this PR:
tools/regz/src/gen.zig:421: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/gen.zig:526: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/gen.zig:679: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/gen.zig:729: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/gen.zig:829: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/gen.zig:1069: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/gen.zig:1071: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/gen.zig:1152: TODO style comments need to have a linked microzig issue on the same line.
mattnite
force-pushed
the
uncomment-regz-tests
branch
from
de136dc to
4125874
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Back when I changed the filesystem layout of generated output, I commented out a bunch of tests, this patch finishes moving them over to the new system. Currently two fail so I'm keeping them commented out, and will fix after I've migrated regz to the new sqlite package (#808)