STM32 Align RCC clock enable function for all HAL#825
Merged
mattnite merged 1 commit intoZigEmbeddedGroup:mainfrom Jan 4, 2026
Merged
STM32 Align RCC clock enable function for all HAL#825mattnite merged 1 commit intoZigEmbeddedGroup:mainfrom
mattnite merged 1 commit intoZigEmbeddedGroup:mainfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🔍 Lint Results
Found 5 issues on changed lines in 3 files:
- port/stmicro/stm32/src/hals/STM32F103/rcc.zig: 1 issue
- port/stmicro/stm32/src/hals/STM32F303/rcc.zig: 2 issues
- port/stmicro/stm32/src/hals/STM32L47X/rcc.zig: 2 issues
ℹ️ Additional issues on unchanged lines
The following 14 issue(s) exist but are not on lines changed in this PR:
port/stmicro/stm32/src/hals/STM32F103/rcc.zig:2: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/STM32F103/rcc.zig:262: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/STM32F303/rcc.zig:28: Suggestion: Rename `RccErrorConfig` to `RCC_ErrorConfig`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/i2c_v2.zig:65: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/i2c_v2.zig:76: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/i2c_v2.zig:109: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/i2c_v2.zig:13: Suggestion: Rename `I2CError` to `I2C_Error`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/i2c_v2.zig:21: Suggestion: Rename `TimingSpec_Standard` to `TimingSpecStandard`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/pins_v2.zig:47: Suggestion: Rename `InputGPIO` to `Input_GPIO`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/pins_v2.zig:58: Suggestion: Rename `OutputGPIO` to `Output_GPIO`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/uart_v3.zig:79: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/uart_v3.zig:81: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/uart_v3.zig:84: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/uart_v3.zig:226: TODO style comments need to have a linked microzig issue on the same line.
mathk
force-pushed
the
stm32-common-clock-enable
branch
from
965446a to
5496983
Compare
github-actions
bot
dismissed
their stale review
Updating with new lint results
There was a problem hiding this comment.
🔍 Lint Results
ℹ️ Additional issues on unchanged lines
The following 18 issue(s) exist but are not on lines changed in this PR:
port/stmicro/stm32/src/hals/STM32F103/rcc.zig:2: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/STM32F103/rcc.zig:262: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/STM32F303/rcc.zig:28: Suggestion: Rename `RccErrorConfig` to `RCC_ErrorConfig`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/i2c_v2.zig:65: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/i2c_v2.zig:76: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/i2c_v2.zig:109: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/i2c_v2.zig:13: Suggestion: Rename `I2CError` to `I2C_Error`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/i2c_v2.zig:21: Suggestion: Rename `TimingSpec_Standard` to `TimingSpecStandard`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/pins_v2.zig:47: Suggestion: Rename `InputGPIO` to `Input_GPIO`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/pins_v2.zig:58: Suggestion: Rename `OutputGPIO` to `Output_GPIO`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/uart_v3.zig:79: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/uart_v3.zig:81: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/uart_v3.zig:84: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/uart_v3.zig:226: TODO style comments need to have a linked microzig issue on the same line.
port/wch/ch32v/src/hals/clocks.zig:14: TODO style comments need to have a linked microzig issue on the same line.
port/wch/ch32v/src/hals/clocks.zig:150: TODO style comments need to have a linked microzig issue on the same line.
port/wch/ch32v/src/hals/clocks.zig:173: TODO style comments need to have a linked microzig issue on the same line.
port/wch/ch32v/src/hals/i2c.zig:16: Suggestion: Rename `I2cRegs` to `I2C_Regs`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
5496983 to
0b46263
Compare
There was a problem hiding this comment.
🔍 Lint Results
ℹ️ Additional issues on unchanged lines
The following 14 issue(s) exist but are not on lines changed in this PR:
port/stmicro/stm32/src/hals/STM32F103/rcc.zig:2: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/STM32F103/rcc.zig:262: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/STM32F303/rcc.zig:28: Suggestion: Rename `RccErrorConfig` to `RCC_ErrorConfig`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/i2c_v2.zig:65: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/i2c_v2.zig:76: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/i2c_v2.zig:109: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/i2c_v2.zig:13: Suggestion: Rename `I2CError` to `I2C_Error`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/i2c_v2.zig:21: Suggestion: Rename `TimingSpec_Standard` to `TimingSpecStandard`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/pins_v2.zig:47: Suggestion: Rename `InputGPIO` to `Input_GPIO`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/pins_v2.zig:58: Suggestion: Rename `OutputGPIO` to `Output_GPIO`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/uart_v3.zig:79: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/uart_v3.zig:81: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/uart_v3.zig:84: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/uart_v3.zig:226: TODO style comments need to have a linked microzig issue on the same line.
0b46263 to
158bb1c
Compare
mathk
force-pushed
the
stm32-common-clock-enable
branch
from
158bb1c to
43029cc
Compare
mattnite
approved these changes
Jan 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.