This repository was archived by the owner on Aug 27, 2025. It is now read-only.
Merged
Conversation
A long running heap profile of the Scilla process from a ZQ2 node showed growing memory usage. The allocations were mainly happening in `add_comment`. I'm not sure why/where we retain the reference to this forever, but I did see that the only user of `get_comments` was `scilla-fmt`, which we are not using. Therefore, I did the easy fix and removed `scilla-fmt`.
JamesHinshelwood
requested review from
86667,
DrZoltanFazekas,
bzawisto and
shawn-zil
bzawisto
approved these changes
May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A long running heap profile of the Scilla process from a ZQ2 node showed growing memory usage. The allocations were mainly happening in
add_comment. I'm not sure why/where we retain the reference to this forever, but I did see that the only user ofget_commentswasscilla-fmt, which we are not using.Therefore, I did the easy fix and removed
scilla-fmt.Heap profile before:
Heap profile after:
We are allocating roughly the same amount, but the memory usage doesn't keep growing because the GC can do its job.