Skip to content

Skip invalid early proposal#3597

Merged
shawn-zil merged 2 commits into
mainfrom
shawn/3596/fix-early-proposal
Apr 22, 2026
Merged

Skip invalid early proposal#3597
shawn-zil merged 2 commits into
mainfrom
shawn/3596/fix-early-proposal

Conversation

@shawn-zil
Copy link
Copy Markdown
Collaborator

@shawn-zil shawn-zil commented Apr 22, 2026

On an API node, the pending block only gets updated when manually triggered by an appropriate call. A new transaction is validated against the state in the pending block. So, stale state is used to validate transactions upon submission. This PR ignores the pending block and always checks against the present state.

This issue surfaced on devnet because it does not get much traffic and the pending block does not get updated regularly.

@shawn-zil shawn-zil linked an issue Apr 22, 2026 that may be closed by this pull request
@shawn-zil shawn-zil force-pushed the shawn/3596/fix-early-proposal branch from 12b7d64 to a4710a1 Compare April 22, 2026 02:57
@shawn-zil shawn-zil changed the title Remove early proposal caching Skip invalid early proposal Apr 22, 2026
@shawn-zil shawn-zil force-pushed the shawn/3596/fix-early-proposal branch from a4710a1 to 34d6bf2 Compare April 22, 2026 02:58
@shawn-zil shawn-zil force-pushed the shawn/3596/fix-early-proposal branch from c31d4b4 to f64a859 Compare April 22, 2026 03:43
@shawn-zil shawn-zil force-pushed the shawn/3596/fix-early-proposal branch from f64a859 to 30f436f Compare April 22, 2026 03:43
@github-actions
Copy link
Copy Markdown
Contributor

🐰 Bencher Report

Branchshawn/3596/fix-early-proposal
Testbedself-hosted
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
milliseconds (ms)
(Result Δ%)
Upper Boundary
milliseconds (ms)
(Limit %)
full-blocks-erc20-transfers/full-blocks-erc20-transfers📈 view plot
🚷 view threshold
609.88 ms
(-2.10%)Baseline: 622.95 ms
680.55 ms
(89.62%)
full-blocks-evm-transfers/full-blocks-evm-transfers📈 view plot
🚷 view threshold
854.57 ms
(-1.73%)Baseline: 869.61 ms
981.44 ms
(87.07%)
full-blocks-giant-deploy/full-blocks-giant-deploy📈 view plot
🚷 view threshold
5,099.90 ms
(-1.47%)Baseline: 5,175.95 ms
5,635.71 ms
(90.49%)
full-blocks-scilla-add/full-blocks-scilla-add📈 view plot
🚷 view threshold
1,018.70 ms
(-0.28%)Baseline: 1,021.58 ms
1,070.52 ms
(95.16%)
full-blocks-scilla-load/full-blocks-scilla-load📈 view plot
🚷 view threshold
5,639.30 ms
(+1.87%)Baseline: 5,535.87 ms
6,627.27 ms
(85.09%)
full-blocks-scilla-store/full-blocks-scilla-store📈 view plot
🚷 view threshold
4,360.50 ms
(+0.14%)Baseline: 4,354.32 ms
5,080.99 ms
(85.82%)
full-blocks-zil-transfers/full-blocks-zil-transfers📈 view plot
🚷 view threshold
1,046.10 ms
(-3.54%)Baseline: 1,084.51 ms
1,357.49 ms
(77.06%)
process-empty/process-empty📈 view plot
🚷 view threshold
13.63 ms
(+6.23%)Baseline: 12.83 ms
16.85 ms
(80.91%)
🐰 View full continuous benchmarking report in Bencher

@shawn-zil shawn-zil enabled auto-merge April 22, 2026 06:09
@shawn-zil shawn-zil added this pull request to the merge queue Apr 22, 2026
Merged via the queue into main with commit 2f947b2 Apr 22, 2026
6 of 7 checks passed
@shawn-zil shawn-zil deleted the shawn/3596/fix-early-proposal branch April 22, 2026 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Possible state/account stale caching issue

2 participants