feat: UN-2166 Passed optional container name from backend to runner#1158
Conversation
…a private lib that's added, the lockfile can't be resolved and pushed
muhammad-ali-e
left a comment
There was a problem hiding this comment.
LGTM overall, left few NITs
|
|
ritwik-g
left a comment
There was a problem hiding this comment.
I feel like you have combined way too many changes in to this one PR making it a bit difficult to review. If the PR only had the container name related changes it would have been easier to review. Keeping the PR with single responsibility help the reviewers. Especially with some items like file_name removal the new retry count logic in the name. With all these changes am finding it difficult to review the PR.
When we are not hard pressed for time this might be something passable. But now since we are trying to take this change quickly in the other changes are becoming an unnecessary burden. It takes longer to review and the chances for bugs also increases.
Anyway since @muhammad-ali-e has approved I would consider this relatively okay. For some items outside runner I don't have enough context to understand the changes. So I am not thoroughly reviewing those.
But I have left one comment which needs to be addressed. Please check that
…1158) * UN-2166 Passed optional container name from backend to runner * Removed tool-sandbox from lockfile automation script - since core is a private lib that's added, the lockfile can't be resolved and pushed * minor: Addressed review comments for renaming a variable



What
backendtorunnerrun_idtofile_execution_idin parts concerning WF executionWhy
backendand a different one was generated and used by therunnerwhich resulted in confusion during debugging and tracingHow
runnerCan this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
Dependencies Versions
unstract-coretounstract-tool-sandboxNotes on Testing
Screenshots
Checklist
I have read and understood the Contribution Guidelines.