Fix file upload security loopholes#14
Merged
nehabagdia merged 7 commits intomainfrom Feb 29, 2024
Merged
Conversation
gaya3-zipstack
requested review from
Deepak-Kesavan,
chandrasekharan-zipstack,
hari-kuriakose and
nehabagdia
jaags-dev
approved these changes
Feb 29, 2024
nehabagdia
approved these changes
Feb 29, 2024
|
|
||
| from django.core.exceptions import ValidationError | ||
| from django.template.defaultfilters import filesizeformat | ||
| from django.utils.translation import gettext_lazy as _ |
Contributor
There was a problem hiding this comment.
@gaya3-zipstack are these imports used? Did you run it against pre-commit
|
|
||
| class FileUploadSerializer(serializers.Serializer): | ||
| file = serializers.ListField(child=serializers.FileField(), required=True) | ||
| file = serializers.ListField( |
Contributor
There was a problem hiding this comment.
@gaya3-zipstack will this impact file upload for workflows / API deployment as well? We'll have other file types to allow in that case
pk-zipstack
pushed a commit
that referenced
this pull request
Aug 20, 2025
* Add file upload validation * Code formatting * Code formatting * Change values to constants
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
While a file is uploaded to Prompt studio for indexing, file checks are missing and hence this can cause security issues.
Why
Security loopholes will enable attackers to upload malicious content and in turn cause various types of attacks on the Unstract system.
How
Prevented using the following types of checks
Relevant Docs
Related Issues or PRs
Dependencies Versions / Env Variables
Notes on Testing
Screenshots
...
Checklist
I have read and understood the Contribution Guidelines.