UN-3039 [FIX] Fix custom_data string values being wrapped in extra quotes #1746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otes Pass raw value to replace_generic_string_value instead of pre-formatting with json.dumps, so string values are inserted directly without quotes. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
WalkthroughThe refactoring relocates JSON and string type formatting logic within the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~4 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jagadeeswaran-zipstack
requested review from
Deepak-Kesavan,
athul-rs,
harini-venkataraman and
vishnuszipstack
harini-venkataraman
approved these changes
Jan 19, 2026
vishnuszipstack
approved these changes
Jan 19, 2026
Deepak-Kesavan
approved these changes
Jan 19, 2026
…le-pass-mode-is-turned-on
…le-pass-mode-is-turned-on
Contributor
Test ResultsSummary
Runner Tests - Full Report
SDK1 Tests - Full Report
|
|
muhammad-ali-e
deleted the
UN-3039-custom-data-not-kicking-in-when-single-pass-mode-is-turned-on
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
When custom_data contained string values (e.g.,
{"data": "resume"}), thereplace_custom_data_variablefunction was callingjson.dumps()on all values, which wrapped strings in extra quotes. This caused{{custom_data.data}}to be replaced with"resume"instead ofresume.How
replace_custom_data_variable()invariable_replacement.pyto pass the raw value toreplace_generic_string_value()instead of pre-formatting withjson.dumps()replace_generic_string_value()already has logic to only applyjson.dumps()for non-string valuesCan this PR break any existing features? If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
No. This fixes incorrect behavior. String values will now be inserted directly without quotes, while non-string values (dicts, lists, numbers) will still be properly JSON-serialized.
Relevant Docs
Related Issues or PRs
Dependencies Versions / Env Variables
Notes on Testing
Screenshots
...
Checklist
I have read and understood the Contribution Guidelines.