fix: fix Minimal Tests workflow for OSS repo structure

[abhizipstack]

What

• Fix the disabled Minimal Tests CI workflow for the OSS repo structure
• Enable SonarCloud integration for Python backend coverage
• Fix outdated test (incremental validation)

Why

• The Minimal Tests workflow was disabled due to failures from old repo structure references
• SonarCloud was not configured — needed for code quality tracking on the public repo
• Tests need to pass in CI before we can enforce required status checks

How

• setup-python action: Fixed cache path to backend/uv.lock, run uv sync --group test from backend/
• Workflow: Python 3.10, working-directory: backend, DJANGO_SETTINGS_MODULE env var
• Test paths: Run ../tests/unit, ignore broken dirs (test_logs, test_visitran_adapters, test_visitran_backend)
• Pre-commit: Removed — handled by pre-commit.ci
• SonarCloud: Project key Zipstack_visitran, continue-on-error until baseline
• Test fix: test_invalid_model_no_primary_key → primary_key is now optional (APPEND mode)

Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)

• No — only modifies CI workflow, setup action, SonarCloud config, and one test assertion. No application code changes.

Database Migrations

• None

Env Config

• DJANGO_SETTINGS_MODULE=backend.server.settings.dev — CI workflow only
• SONAR_TOKEN — already in repo secrets

Relevant Docs

• SonarCloud: https://sonarcloud.io/project/overview?id=Zipstack_visitran

Related Issues or PRs

• Replaces PR fix: fix Minimal Tests workflow for OSS repo structure #18 (had rebase conflicts)
• Depends on PR fix: configure pre-commit.ci and clean up codebase formatting #29 (merged)

Dependencies Versions

• Python 3.10 (changed from 3.11)

Notes on Testing

• Verified locally: 23 tests passed, 0 failed
• After merge: workflow is already enabled in Actions

Screenshots

N/A

Checklist

I have read and understood the Contribution Guidelines.

[greptile-apps]

Greptile Summary

This PR fixes the broken Minimal Tests CI workflow by correcting path references for the OSS monorepo layout, enabling SonarCloud integration, and updating one test to reflect that primary_key is now optional (APPEND mode) in incremental models.

Key changes:

• setup-python action: Cache path corrected to backend/uv.lock; uv sync now runs from backend/ with the --group test flag.
• Workflow YAML: Fixed broken indentation (was the root cause of the disabled workflow), switched to Python 3.10, set working-directory: backend as the job default, added DJANGO_SETTINGS_MODULE, and scoped test paths to ../tests/unit with explicit ignore dirs.
• SonarCloud: Pinned to @v3 (from @master), added continue-on-error: true for baseline establishment, and corrected sonar.python.coverage.reportPaths to backend/coverage.xml — matching where uv run coverage xml actually writes the file.
• Test: test_invalid_model_no_primary_key renamed and updated to assert no error is raised, reflecting the APPEND-mode fallback behaviour now in production code. The fixture class name/docstring still reads "Invalid" which is now misleading (P2).

Confidence Score: 5/5

• Safe to merge — all previously flagged P1 issues (coverage path mismatch, unpinned @master) are resolved; only minor P2 style/robustness suggestions remain.
• Both prior review concerns are fully addressed: the SonarCloud action is pinned to @V3 and the coverage report path is now correctly set to backend/coverage.xml. The remaining findings are a misleading test-fixture name (cosmetic) and a potentially fragile git fetch --unshallow (edge-case, non-blocking). No application logic is changed.
• tests/unit/test_incremental_validation.py — fixture class name/docstring still says "Invalid" after the behavioral inversion.

Important Files Changed

Filename	Overview
.github/actions/setup-python/action.yaml	Fixed cache-dependency-path to backend/uv.lock and added working-directory + --group test to uv sync; structurally clean.
.github/workflows/core-backend-tests.yaml	Reformatted YAML (fixed indentation that was breaking the workflow), switched to Python 3.10, added working-directory defaults, DJANGO_SETTINGS_MODULE env var, and SonarCloud step pinned to @V3 with continue-on-error.
sonar-project.properties	Updated project key to Zipstack_visitran and corrected coverage report path to backend/coverage.xml, now consistent with coverage xml output location.
tests/unit/test_incremental_validation.py	Renamed test to reflect APPEND-mode behavior; test class docstring and name still say "Invalid" which is now misleading.

Sequence Diagram

sequenceDiagram
    participant GH as GitHub Actions
    participant Setup as setup-python action
    participant UV as uv (backend/)
    participant Coverage as coverage.xml (backend/)
    participant Sonar as SonarCloud

    GH->>GH: checkout (shallow, depth=1)
    GH->>Setup: python-version=3.10
    Setup->>UV: cache backend/uv.lock
    Setup->>UV: uv sync --group test (cwd: backend/)
    GH->>UV: uv run coverage run ... pytest ../tests/unit (cwd: backend/)
    UV-->>Coverage: writes backend/coverage.xml
    GH->>GH: git fetch --unshallow (cwd: .)
    GH->>Sonar: sonarcloud-github-action@v3 (projectBaseDir: ./)
    Sonar->>Coverage: reads backend/coverage.xml ✓

Loading

Prompt To Fix All With AI

This is a comment left during a code review.
Path: tests/unit/test_incremental_validation.py
Line: 24-34

Comment:
**Misleading class name and docstring after behavioral change**

The class is still named `InvalidIncrementalModelNoPrimaryKey` with the docstring `"Invalid incremental model missing primary key."` — but the test now asserts that this configuration is perfectly valid (APPEND mode). This is confusing for future readers who may expect this fixture to represent a broken model. Consider renaming it to something like `IncrementalModelWithoutPrimaryKey` to match the new semantics.

```suggestion
class IncrementalModelWithoutPrimaryKey(VisitranModel):
    """Incremental model without a primary key — uses APPEND mode."""

    def __init__(self):
        super().__init__()
        self.materialization = Materialization.INCREMENTAL
        # No primary_key — incremental falls back to APPEND mode
        self.delta_strategy = create_timestamp_strategy(column="updated_at")

    def select(self):
        return None
```

How can I resolve this? If you propose a fix, please make it concise.

---

This is a comment left during a code review.
Path: .github/workflows/core-backend-tests.yaml
Line: 57-59

Comment:
**`git fetch --unshallow` will fail on a complete repository**

`git fetch --unshallow` exits with a fatal error (`fatal: --unshallow on a complete repository does not make sense`) if the clone is already unshallow (e.g., on a `workflow_dispatch` triggered from a full clone, or if the checkout step is ever changed to `fetch-depth: 0`). Since this step has no `continue-on-error`, that failure would abort the workflow before SonarCloud runs.

A common defensive pattern is:

```suggestion
      - name: Git fetch unshallow
        working-directory: .
        run: git fetch --unshallow || true
```

How can I resolve this? If you propose a fix, please make it concise.

_{Reviews (2): Last reviewed commit: "fix: address Greptile review — coverage ..." | Re-trigger Greptile}

[tahierhussain]

LGTM