Skip to content

fix: release notification secrets context and script injection #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abhizipstack merged 2 commits into from
Apr 8, 2026
Merged

fix: release notification secrets context and script injection #50

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6d5e67
fix: release notification — secrets context and script injection
abhizipstack Apr 8, 2026
2bc148b
fix: build full JSON payload in shell to prevent JSON injection
abhizipstack Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions .github/workflows/release-notification.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,23 +7,24 @@ on:
jobs:
notify:
runs-on: ubuntu-latest
if: ${{ secrets.SLACK_WEBHOOK_URL != '' }}
steps:
- name: Build Slack message
- name: Build Slack payload
id: message
if: ${{ env.SLACK_WEBHOOK_URL != '' }}
env:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
TAG: ${{ github.event.release.tag_name }}
RELEASE_NAME: ${{ github.event.release.name }}
URL: ${{ github.event.release.html_url }}
run: |
echo "text=🚀 *Visitran ${TAG}* released! ${RELEASE_NAME} <${URL}|View Release Notes>" >> "$GITHUB_OUTPUT"
TEXT=$(printf '🚀 *Visitran %s* released! %s <%s|View Release Notes>' "$TAG" "$RELEASE_NAME" "$URL")
PAYLOAD=$(jq -nc --arg text "$TEXT" '{"text": $text}')
echo "payload=$PAYLOAD" >> "$GITHUB_OUTPUT"

- name: Post to Slack
if: ${{ steps.message.outputs.payload != '' }}
uses: slackapi/slack-github-action@v2.1.0
with:
webhook: ${{ secrets.SLACK_WEBHOOK_URL }}
webhook-type: incoming-webhook
payload: |
{
"text": "${{ steps.message.outputs.text }}"
}
payload: ${{ steps.message.outputs.payload }}
Loading