Add public plugin_report_get_data() API#88
Open
apermo wants to merge 4 commits intoZodiac1978:developfrom
Open
Add public plugin_report_get_data() API#88apermo wants to merge 4 commits intoZodiac1978:developfrom
apermo wants to merge 4 commits intoZodiac1978:developfrom
Conversation
6 tasks
Add RT_Plugin_Report::get_report() static method and a global plugin_report_get_data() wrapper as public API for other plugins to access report data without touching transients directly. Populates cache on demand if not yet available.
isset() on null already returns false, no need for the redundant truthy check.
Use a static local instance in the global wrapper instead of instantiating inside the class method.
apermo
force-pushed
the
feature/public-api
branch
from
4694942 to
e60cab4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RT_Plugin_Report::get_report( $slug )static method as the canonical way to read report dataplugin_report_get_data( $slug )convenience wrapper for use by other pluginsself::get_report()internallyFixes #87
Test in WordPress Playground
Before (develop — baseline): Open in WordPress Playground
After (this branch — public API added): Open in WordPress Playground
Pre-installed test plugins: Apermo Admin Bar (outdated), giWeather (closed/removed)
Test plan
function_exists( 'plugin_report_get_data' )returns true when plugin is activeplugin_report_get_data('akismet')returns report data