Handle interrupted AJAX calls gracefully#95
Open
apermo wants to merge 1 commit intoZodiac1978:developfrom
Open
Handle interrupted AJAX calls gracefully#95apermo wants to merge 1 commit intoZodiac1978:developfrom
apermo wants to merge 1 commit intoZodiac1978:developfrom
Conversation
Add .fail() handler to the AJAX call so a network error or server failure shows an error row instead of stopping the entire chain. Wrap JSON.parse in try/catch for malformed responses. Processing continues to the next plugin in both cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.fail()handler to the AJAX call — a network error or server 500 now shows an error row instead of stopping the entire chainJSON.parsein try/catch for malformed responsesFixes #67
Relates to #92 which prevents the server-side from failing in the first place — this PR handles the case where the request itself fails (network, timeout, server error).
Test in WordPress Playground
Open in WordPress Playground
Pre-installed test plugins: Apermo Admin Bar (outdated), giWeather (closed/removed)
Test plan