fix: decouple container usage from runner label#75
Merged
Conversation
The container and setup-ubuntu-packages conditions were hardcoded to only activate when runs_on == 'zondax-runners'. This prevented other runner labels (e.g. kunobi-runners) from using the Docker container, causing jobs to fail with missing tools (cargo, node, etc). Replace the runner label check with runner_preset != 'macos-arm64', which correctly enables containers for all Linux runners regardless of their label. Affected workflows: - _checks-rs.yaml - _checks-ts.yaml - _checks-links.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
runs_on == 'zondax-runners'check from container and setup-ubuntu-packages conditionsrunner_preset != 'macos-arm64'which correctly enables containers for all Linux runners regardless of their labelkunobi-ninja) using custom runner labels (e.g.kunobi-runners) get bare-metal execution without the Docker container, causing missing tools (cargo,node, etc.)Affected workflows
_checks-rs.yaml_checks-ts.yaml_checks-links.yamlTest plan
zondax-runners(no behavior change)kunobi-runnersnow gets the container withzondax/ubuntu-ci:22.04