Fix: Implement ABI Method Num to Actor Method name correctly#299
Merged
Conversation
emmanuelm41
approved these changes
Mar 4, 2025
JulianToledano
approved these changes
Mar 5, 2025
Contributor
JulianToledano
left a comment
JulianToledano
left a comment
There was a problem hiding this comment.
LGTM! just a couple of comments!
lucaslopezf
reviewed
Mar 7, 2025
Contributor
lucaslopezf
left a comment
lucaslopezf
left a comment
There was a problem hiding this comment.
I love it!!! Let's remove the debug lines (prinln) and as important only one comment (the one that we can have error in runtime, the other comments are mostly for later consideration)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version-Aware Actor Method Resolution
This PR deprecates
GetMethodName(abi.MethodNum)due to its reliance on a specific builtin-actors version, causing inaccurate results for varying actor versions. Instead, V2 actors now provideMethods(network, height, abi.MethodNum...), which dynamically retrieves method metadata from the correct actor version based on network and height. This ensures accurate method resolution across all actor versions.🔗 zboto Link