fix: prevent settings being overwritten with defaults on server start#565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
YAML is always the source of truth. getData() reads from it, saveData() writes to it. The bug was that saveData() was writing incorrect data because loadStatsOnlyData() never loaded settings into memory.
Because it's a race condition between AutoSaveRunnable and the player's input:
Normally (there is no bug):
The server started → the player logged in after 5 seconds → ensureFullDataLoaded() loaded sidebar = true → autosave sees true after 5 minutes → saves true
Bug (sometimes):
The server has started → the player has NOT logged in for 5+ minutes → AutoSaveRunnable has started → saveData() sees sidebar = false (not loaded yet) → writes false in YAML