Support quoting config variables#2175
Merged
connortechnology merged 3 commits intoZoneMinder:masterfrom Aug 11, 2018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking into the following issue in the user forum revealed that ZoneMinder treats quotes as part of the string: https://forums.zoneminder.com/viewtopic.php?f=37&t=27435
This pr allows proper handling of quoted strings. It also surrounds zm_path_arp in quotes in the default config file because cmake can populate this at build time with "/path/to/ip neigh".
One could make an argument that we should surround all config variables in quotes by default, but I stopped short of doing that.