Display a modal window confirming the deletion of a user on Options page -> users#4749
Merged
connortechnology merged 12 commits intoZoneMinder:masterfrom May 1, 2026
Merged
Conversation
…dals\delconfirm.php file. - Added the "DeleteUser" function to be executed when the "Delete" button is clicked.
Contributor
Author
|
Done. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a delete-confirmation modal to the Options → Users tab so user deletions require explicit confirmation.
Changes:
- Load and inject the shared
delconfirmmodal via Ajax on the Options page and bind confirm to submit the users delete form. - Update the Users delete button to open the modal instead of submitting immediately.
- Add new translation keys for the user-deletion confirmation title/body (EN/RU) and allow the modal title to be parameterized.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| web/skins/classic/views/js/options.js | Loads delconfirm modal and binds confirm action to submit the users form; adds DeleteUser handler. |
| web/skins/classic/views/_options_users.php | Switches delete button to type="button" and wires it to DeleteUser via data-on-click-this. |
| web/lang/en_gb.php | Adds EN strings for user deletion confirm modal title/body. |
| web/lang/ru_ru.php | Adds RU strings for user deletion confirm modal title/body; tweaks existing delete title string. |
| web/ajax/modals/delconfirm.php | Accepts a request parameter to control the modal title translation key. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
Done. |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
I tested adding large amounts of data to the DOM, and the synchronous operation of "replaceWith" and "append" in the insertModalHtml() function works quite correctly. This was just my extra precaution.
Contributor
Author
|
Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.