Provide the user with up-to-date information about the supported version of audioMotionAnalyzer#4753
Merged
Merged
Conversation
This is necessary to determine whether we are using the analyzer, and if so, what version it is. We will then provide the user with useful information when they are in the Viewing tab.
- Now we only specify the supported analyzer version in one place in the audioMotionAnalyzer.js file - Added translations for three cases: when the analyzer is not installed, the wrong version is installed, or everything is fine.
Contributor
Author
|
Done |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds UI messaging on the Monitor “Viewing” tab to inform users whether the installed audioMotionAnalyzer matches the supported version, and provides install/update guidance.
Changes:
- Adds a “WhatDisplayInfo” help text area under the “Show” selector on the Monitor Viewing tab and populates it via JS based on detected analyzer version.
- Exposes new i18n strings for “OK / not installed / wrong version” messaging, plus version template substitution in the UI.
- Loads the
audioMotionAnalyzermodule on the Monitor page and updates bundled help text to avoid hardcoding a specific CDN version.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| web/skins/classic/views/monitor.php | Adds #WhatDisplayInfo placeholder below the “Show” control. |
| web/skins/classic/views/js/monitor.js.php | Exports new translated strings to JS for version-status messaging. |
| web/skins/classic/views/js/monitor.js | Adds version-check logic and template replacement for display under “Show”. |
| web/skins/classic/js/audioMotionAnalyzer.js | Introduces supported-version constant and sets a global “current version” for UI consumption; adjusts custom element registration. |
| web/skins/classic/includes/functions.php | Ensures audioMotionAnalyzer.js is loaded on the Monitor page. |
| web/skins/classic/assets/audioMotion-analyzer/src/help.txt | Generalizes CDN URL instructions to not hardcode a specific version. |
| web/lang/ru_ru.php | Adds RU translations for analyzer version status messages; updates related help text. |
| web/lang/en_gb.php | Adds EN translations for analyzer version status messages; updates related help text. |
| web/includes/lang.php | Changes translate() to convert ~~ into <br/>. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Oh, my bad English :( Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
We check for the file's existence, and if it does, we set AUDIO_MOTION_ENABLED = true. Okay, let's do an additional check in case the import fails for some reason. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ON_ANALYZER_VERSION value (monitor.js) https://github.com/ZoneMinder/zoneminder/pull/4753/changes#r3158319956
Contributor
Author
|
@connortechnology |
…k() & replaceDoubleTildeToBR() (monitor.js)
Contributor
Author
|
@connortechnology |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the user is in the Viewing tab on the Monitor page, we'll provide them with useful information about audioMotionAnalyzer (supported version number, download links, etc.).