Support choosing terminal profile for inline terminal executaion

[chenyuanrun]

Is your feature request related to a problem? Please describe.
I use Chinese under Windows and the default charset is GBK but not utf-8, the default ZooCode inline terminal is cmd/powershell and will print wrong char for my utf-8 project.

Describe the solution you'd like
I can use git bash to execute command in inline termianl, whose default encoding is utf-8.

Describe alternatives you've considered
No

Additional context

[proyectoauraorg]

Looking into this — adding a setting to choose the terminal profile/shell for inline execution (so e.g. git bash with UTF-8 can be used on Windows). PR incoming.

[F915]

Thanks for raising this. I ran into the same issue and did a deeper investigation. I think the problem goes beyond just encoding — there's a shell mismatch between what the AI is told to generate and what actually executes.

Root cause analysis

Zoo Code has a getShell() function in src/utils/shell.ts that correctly detects the user's configured shell (e.g., PowerShell 7) from VSCode settings. This detection is used to generate the AI system prompt (so the AI knows to use pwsh syntax like Write-Host, $env:VAR, ; as command separator, etc.).

However, the detected shell is NOT passed to the actual terminal creation.

Zoo Code has two terminal execution paths:

Path 1: Inline Terminal (execa) — DEFAULT

// ExecaTerminalProcess.ts:43
shell: BaseTerminal.getExecaShellPath() || true,  // true → cmd.exe on Windows

Since getExecaShellPath() is undefined by default, shell: true resolves to cmd.exe on Windows. This completely bypasses the user's configured shell.

Path 2: Zoo Code terminal (secondary path, used when Inline Terminal is disabled)

// Terminal.ts:21
this.terminal = terminal ?? vscode.window.createTerminal({ cwd, name: "Roo Code", iconPath, env })
// missing: shellPath

Without shellPath, VSCode's createTerminal falls back to cmd.exe in many cases. Note: this is Zoo Code's own terminal (named "Roo Code"), created via the VSCode Terminal API, not the user's built-in VSCode terminal.

Observable symptoms

Symptom A: Shell mismatch (commands fail)

AI generates (pwsh):    Write-Host "test"
Actually executes (cmd.exe):  'Write-Host' 不是内部或外部命令，也不是可运行的程序或批处理文件。(but garbled Chinese text)

Symptom B: Encoding garble (non-ASCII output corrupted)

Command:  chcp
Expected: 活动代码页: 65001
Actual:   (garbled Chinese text)

Command:  echo 中文测试
Expected: 中文测试
Actual:   (garbled Chinese text)

The encoding issue is a secondary symptom of running in cmd.exe (which uses CP936 on Chinese Windows) instead of pwsh (which defaults to UTF-8). Even chcp 65001 && echo 中文 doesn't help because cmd.exe parses the command text using the current code page before chcp executes.

Proposed fix

This can be fixed by connecting the existing getShell() to both terminal creation paths:

ExecaTerminalProcess.ts

+import { getShell } from "../../utils/shell"

- shell: BaseTerminal.getExecaShellPath() || true,
+ shell: BaseTerminal.getExecaShellPath() || getShell(),

Terminal.ts

+import { getShell } from "../../utils/shell"

 this.terminal = terminal ?? vscode.window.createTerminal({
-    cwd, name: "Roo Code", iconPath, env
+    cwd, name: "Roo Code", iconPath, env, shellPath: getShell()
 })

getShell() already has a 4-level priority chain (VSCode config → OS user info → env vars → safe platform fallback) with allowlist validation, so this is a minimal and safe change.

Safety

• getShell() validates against a built-in allowlist before returning
• Falls back to cmd.exe if validation fails — no regression for users who haven't configured a custom shell
• Users who call setExecaShellPath() retain priority (left side of || is checked first)
• macOS/Linux users unaffected (native UTF-8 shells)

I've verified this fix locally with a build and test. For reference, I've also submitted a detailed issue report with reproduction steps and proposed fix: #321. Happy to provide any additional information if helpful. Thank you for your time and consideration.