Welcome screen fix#163
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR fixes a bug where the welcome screen content is cut off when history exceeds four items. The layout changes the no-task container from a centered layout to a scrollable vertical flex layout with auto-centering, allowing content to scroll rather than overflow outside the viewport. ChangesWelcome Screen Scrollable Layout
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
webview-ui/src/components/chat/ChatView.tsxOops! Something went wrong! :( ESLint: 9.28.0 ESLint couldn't find an eslint.config.(js|mjs|cjs) file. From ESLint v9.0.0, the default configuration file is now eslint.config.js. https://eslint.org/docs/latest/use/configure/migration-guide If you still have problems after following the migration guide, please stop by Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Related GitHub Issue
Closes: #162
Description
The welcome screen (displayed when no task is active) used
justify-centeron both the outer scroll container and inner content wrapper. This is a well-known CSS flexbox pitfall: when content overflows the container,justify-centerpositions the content at the geometric center of the flex container, pushing the top portion above the scroll boundary. Since browsers cannot scroll to negative offsets, the top content (RooHero, RooTips) becomes permanently unreachable.This manifests when
HistoryPreviewshows 4 task groups (the max it displays viagroups.slice(0, 4)), which combined with RooHero and RooTips exceeds the sidebar viewport height.Fix: Replace
justify-centerwith themy-autopattern on the inner content wrapper inChatView.tsx:justify-center(keepsoverflow-y-autoandmin-h-0for scrolling)justify-center h-fullwithmy-autoThe
my-autopattern (margin-top: auto; margin-bottom: auto) centers content when it fits within the viewport (auto margins split free space equally), but gracefully falls back to top-alignment when content overflows (auto margins collapse to 0), allowingoverflow-y-autoto scroll to all content.Roadmap alignment: Enhanced User Experience — fixes a friction point where users with task history cannot access the welcome screen hero/tips content.
Test Procedure
webview-uipassespnpm run check-typescleanlyPre-Submission Checklist
Screenshots / Videos
Documentation Updates
Additional Notes
This is a minimal, surgical CSS fix — two class name changes, no logic or component structure modifications. The
my-autopattern is the standard solution for the "flexbox centering overflow" problem (see CSS-Tricks: Flexbox Truncation).Get in Touch
navedmerchant
Summary by CodeRabbit