[Fix] Shift+Enter sends chat message when Ctrl/Cmd+Enter mode is enabled#199
Merged
Merged
Conversation
roomote
Bot
added
the
roomote:auto-resolve-conflicts
Contributor
Author
|
2 checks still pending after the review wait window. See task
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
navedmerchant
requested review from
JamesRobert20,
edelauna,
hannesrudolph,
navedmerchant and
taltas
as code owners
proyectoauraorg
added a commit
to proyectoauraorg/Zoo-Code
that referenced
this pull request
May 19, 2026
…) en CONTRIBUTIONS.md
edelauna
approved these changes
May 19, 2026
Contributor
edelauna
left a comment
edelauna
left a comment
There was a problem hiding this comment.
Thanks, this always bugged me.
This was referenced May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem this solves
Fixes an issue where users who enable Ctrl/Cmd+Enter to send can accidentally send a chat message with
Shift+Enterinstead of inserting a new line in the chat composer.Why this change was made
The newline-mode keyboard handler treated
Shift+Enteras a send shortcut even though that mode is meant to reserve sending for Ctrl/Cmd+Enter. This change narrows the send condition to Ctrl/Cmd+Enter and updates the regression test to lock that behavior in.User impact
Users can keep using
Shift+Enterto add a new line in the chat input, regardless of whether Ctrl/Cmd+Enter to send is enabled.