fix(e2e): replace paths filter with content-hash cache skip#268
Merged
Conversation
Contributor
Author
|
No actionable issues found. See task
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
edelauna
reviewed
May 23, 2026
Contributor
There was a problem hiding this comment.
Adding this in since I'd like for e2e tests to be a required check, but it also doesn't make sense to run them on every PR.
643b78c to
5e6f407
Compare
Contributor
Author
|
I detected merge conflicts but could not start a task to address them. |
Contributor
Author
|
This PR has merge conflicts that need to be resolved. |
Contributor
Author
|
I detected merge conflicts but could not start a task to address them. |
2 similar comments
Contributor
Author
|
I detected merge conflicts but could not start a task to address them. |
Contributor
Author
|
I detected merge conflicts but could not start a task to address them. |
Contributor
Author
|
This PR has merge conflicts that need to be resolved. |
5e6f407 to
efca2b3
Compare
efca2b3 to
c481b89
Compare
edelauna
approved these changes
May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Description
Replaces the
paths:trigger filter on the E2E workflow with a content-hash-keyed cache mechanism.The old
paths:filter caused the E2E required status check to be absent (not just skipped) on PRs that touched files outside the filter, which blocked merging. The new approach:pull_requestevents, restores a pass-marker cache keyed on the hash of all relevant source files.merge_groupandworkflow_dispatchevents always run the full test suite regardless of cache state.Also pins
actions/cache/restoreandactions/cache/saveto their commit SHA (0057852) consistent with the rest of the repo's action pinning.Test Procedure
paths:filter, pluspnpm-workspace.yamland the e2e workflow file itself.Pre-Submission Checklist