Skip to content

fix(e2e): replace paths filter with content-hash cache skip#268

Merged
edelauna merged 1 commit into
mainfrom
issue-267-llm-contribution-guidance-1qq2qyhhsmmi8
May 30, 2026
Merged

fix(e2e): replace paths filter with content-hash cache skip#268
edelauna merged 1 commit into
mainfrom
issue-267-llm-contribution-guidance-1qq2qyhhsmmi8

Conversation

@roomote
Copy link
Copy Markdown
Contributor

@roomote roomote Bot commented May 23, 2026

Related GitHub Issue

Description

Replaces the paths: trigger filter on the E2E workflow with a content-hash-keyed cache mechanism.

The old paths: filter caused the E2E required status check to be absent (not just skipped) on PRs that touched files outside the filter, which blocked merging. The new approach:

  • Always runs the workflow so the required check is always present.
  • On pull_request events, restores a pass-marker cache keyed on the hash of all relevant source files.
  • Skips setup, install, and test steps when the cache hits (same source hash already passed).
  • Writes and saves the pass marker after a successful run so future PRs with the same hash skip automatically.
  • merge_group and workflow_dispatch events always run the full test suite regardless of cache state.

Also pins actions/cache/restore and actions/cache/save to their commit SHA (0057852) consistent with the rest of the repo's action pinning.

Test Procedure

  • Reviewed the workflow diff locally.
  • Cache key covers all source paths previously in the paths: filter, plus pnpm-workspace.yaml and the e2e workflow file itself.

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue.
  • Scope: Changes are focused on the e2e workflow caching fix.
  • Self-Review: Performed a thorough self-review.
  • Testing: CI-only change; validated by workflow logic review.
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

@roomote roomote Bot added the roomote:auto-resolve-conflicts Allow Roomote to auto-resolve merge conflicts for this PR label May 23, 2026
@roomote
Copy link
Copy Markdown
Contributor Author

roomote Bot commented May 23, 2026

No actionable issues found. See task

  • Cache key omits non-core workspace packages that feed the mocked E2E bundle, so this required check can skip on packages/types, packages/ipc, packages/cloud, or packages/telemetry changes.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Comment thread .github/workflows/e2e.yml Outdated
Comment thread .github/workflows/e2e.yml
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding this in since I'd like for e2e tests to be a required check, but it also doesn't make sense to run them on every PR.

@edelauna edelauna force-pushed the issue-267-llm-contribution-guidance-1qq2qyhhsmmi8 branch from 643b78c to 5e6f407 Compare May 23, 2026 22:03
@edelauna edelauna marked this pull request as ready for review May 23, 2026 22:10
@roomote
Copy link
Copy Markdown
Contributor Author

roomote Bot commented May 29, 2026

I detected merge conflicts but could not start a task to address them.

@roomote
Copy link
Copy Markdown
Contributor Author

roomote Bot commented May 29, 2026

This PR has merge conflicts that need to be resolved.

@roomote
Copy link
Copy Markdown
Contributor Author

roomote Bot commented May 30, 2026

I detected merge conflicts but could not start a task to address them.

2 similar comments
@roomote
Copy link
Copy Markdown
Contributor Author

roomote Bot commented May 30, 2026

I detected merge conflicts but could not start a task to address them.

@roomote
Copy link
Copy Markdown
Contributor Author

roomote Bot commented May 30, 2026

I detected merge conflicts but could not start a task to address them.

@roomote
Copy link
Copy Markdown
Contributor Author

roomote Bot commented May 30, 2026

This PR has merge conflicts that need to be resolved.

@edelauna edelauna force-pushed the issue-267-llm-contribution-guidance-1qq2qyhhsmmi8 branch from 5e6f407 to efca2b3 Compare May 30, 2026 12:36
@edelauna edelauna force-pushed the issue-267-llm-contribution-guidance-1qq2qyhhsmmi8 branch from efca2b3 to c481b89 Compare May 30, 2026 12:59
@edelauna edelauna changed the title [Docs] Add LLM contribution guidance to AGENTS.md fix(e2e): replace paths filter with content-hash cache skip May 30, 2026
@edelauna edelauna added this pull request to the merge queue May 30, 2026
Merged via the queue into main with commit 24de98f May 30, 2026
11 checks passed
@edelauna edelauna deleted the issue-267-llm-contribution-guidance-1qq2qyhhsmmi8 branch May 30, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

roomote:auto-resolve-conflicts Allow Roomote to auto-resolve merge conflicts for this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant