Skip to content

chore: remove deprecated requestRooCreditBalance handler#385

Merged
JamesRobert20 merged 1 commit into
mainfrom
chore/remove-deprecated-roo-credit-balance
May 29, 2026
Merged

chore: remove deprecated requestRooCreditBalance handler#385
JamesRobert20 merged 1 commit into
mainfrom
chore/remove-deprecated-roo-credit-balance

Conversation

@JamesRobert20
Copy link
Copy Markdown
Contributor

@JamesRobert20 JamesRobert20 commented May 28, 2026

Summary

  • Removes the no-op requestRooCreditBalance webview handler that only returned an error string.
  • Drops unused requestRooCreditBalance and rooCreditBalance message types from the extension host protocol.

Test plan

  • Extension builds and type-checks pass
  • No webview code references the removed message types

Summary by CodeRabbit

Release Notes

  • Chores
    • Removed Roo credit balance request handling from the VS Code extension message protocol.

Review Change Stack

Drops the no-op webview handler and the unused message types. No callers remain in the extension.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 28, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 0249ebb6-fccd-4d4d-84bc-341d42689ebf

📥 Commits

Reviewing files that changed from the base of the PR and between 6470431 and 097373a.

📒 Files selected for processing (2)
  • packages/types/src/vscode-extension-host.ts
  • src/core/webview/webviewMessageHandler.ts
💤 Files with no reviewable changes (2)
  • src/core/webview/webviewMessageHandler.ts
  • packages/types/src/vscode-extension-host.ts

📝 Walkthrough

Walkthrough

This PR removes Roo credit balance functionality from the VS Code extension/webview message protocol. The "rooCreditBalance" and "requestRooCreditBalance" message type variants are deleted from the protocol definitions, and the corresponding message handler case is removed from the dispatcher.

Changes

Roo Credit Balance Removal

Layer / File(s) Summary
Message type definitions and handler
packages/types/src/vscode-extension-host.ts, src/core/webview/webviewMessageHandler.ts
ExtensionMessage and WebviewMessage type unions remove "rooCreditBalance" and "requestRooCreditBalance" variants respectively; webviewMessageHandler removes the corresponding case branch from the message switch statement.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A message goes to rest today,
Credit balance falls away,
No more balance checks to send,
One less fork in handler's bend! 💫

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is missing critical required sections from the template, including Related GitHub Issue, Description, Test Procedure, and Pre-Submission Checklist. Add the required template sections: link to the GitHub issue in 'Related GitHub Issue', expand 'Description' with implementation details, add actual test steps in 'Test Procedure', and complete the pre-submission checklist.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: removing the deprecated requestRooCreditBalance handler, which aligns with the file modifications shown in the summary.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/remove-deprecated-roo-credit-balance

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 28, 2026

Actionable comments posted: 0

@codecov
Copy link
Copy Markdown

codecov Bot commented May 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@JamesRobert20 JamesRobert20 added this pull request to the merge queue May 29, 2026
Merged via the queue into main with commit 7d601f5 May 29, 2026
10 checks passed
@JamesRobert20 JamesRobert20 deleted the chore/remove-deprecated-roo-credit-balance branch May 29, 2026 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants