Skip to content

Update Z.AI default model to GLM-4.7 #90

Merged
edelauna merged 2 commits into
Zoo-Code-Org:mainfrom
bryce-hoehn:update-glm
May 18, 2026
Merged

Update Z.AI default model to GLM-4.7 #90
edelauna merged 2 commits into
Zoo-Code-Org:mainfrom
bryce-hoehn:update-glm

Conversation

@bryce-hoehn
Copy link
Copy Markdown
Contributor

@bryce-hoehn bryce-hoehn commented May 13, 2026

Related GitHub Issue

#89

Closes: #

Roo Code Task Context (Optional)

Description

Updates default Z.AI model from GLM-4.6 -> GLM-4.7 per recommendation on Z.AI Docs

Test Procedure

Have not tested yet

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Testing: New and/or updated tests have been added to cover my changes (if applicable).
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

Documentation Updates

Additional Notes

Get in Touch

Summary by CodeRabbit

  • Chores
    • Updated default AI model selection to glm-4.7 for both international and Mainland configurations.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 8c1401a0-4cc1-44aa-9e18-9d0c1dfdad3d

📥 Commits

Reviewing files that changed from the base of the PR and between 04738ea and df4e296.

📒 Files selected for processing (1)
  • packages/types/src/providers/zai.ts

📝 Walkthrough

Walkthrough

Two exported constants in the ZAI types file are updated from model version glm-4.6 to glm-4.7: internationalZAiDefaultModelId and mainlandZAiDefaultModelId. All model definitions and pricing remain unchanged.

Changes

ZAI Model Version Update

Layer / File(s) Summary
Update default ZAI model IDs
packages/types/src/providers/zai.ts
Default model identifiers for both international and Mainland configurations are bumped from "glm-4.6" to "glm-4.7".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A hop, a skip, four-point-six takes flight,
Four-point-seven arrives, shiny and bright!
The ZAI defaults now gleam with new grace,
Two strings changed, no models displaced! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is largely incomplete. While it includes a GitHub issue link and a brief description of changes, it lacks required sections like 'Closes:', a detailed test procedure (author states 'Have not tested yet'), and critical pre-submission checklist items are unchecked (Testing and Documentation Impact). Complete the 'Closes:' field with issue #89, provide actual test procedures or rationale for testing exemption, and address the unchecked Testing and Documentation Impact checklist items before merging.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Update Z.AI default model to GLM-4.7' directly and specifically describes the main change in the changeset, which is updating the default model ID from GLM-4.6 to GLM-4.7.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/types/src/providers/zai.ts

Oops! Something went wrong! :(

ESLint: 9.28.0

ESLint couldn't find an eslint.config.(js|mjs|cjs) file.

From ESLint v9.0.0, the default configuration file is now eslint.config.js.
If you are using a .eslintrc.* file, please follow the migration guide
to update your configuration file to the new format:

https://eslint.org/docs/latest/use/configure/migration-guide

If you still have problems after following the migration guide, please stop by
https://eslint.org/chat/help to chat with the team.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Mirrowel
Copy link
Copy Markdown

Honestly it should be changed to latest, 5.1

@roomote
Copy link
Copy Markdown
Contributor

roomote Bot commented May 18, 2026

Follow-up reverted after checking Z.AI docs more closely.

The extra glm-5.1 commit was removed from the PR branch, the PR title/body were restored, and PR 90 is back on the original glm-4.7 direction.

@roomote roomote Bot changed the title Update glm [Improve] Default Z.AI to GLM-5.1 May 18, 2026
@roomote roomote Bot changed the title [Improve] Default Z.AI to GLM-5.1 Update Z.AI default model to GLM-5.1 May 18, 2026
@roomote roomote Bot changed the title Update Z.AI default model to GLM-5.1 Update glm May 18, 2026
@edelauna edelauna marked this pull request as ready for review May 18, 2026 16:12
Copy link
Copy Markdown
Contributor

@edelauna edelauna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this! Read up on the zAI docs, and it does look like the decision to default to 4.7 is correct - with 5.1 being opt-in.

(Also used this PR as a test ground to see if Roomote could update forked PRs)

Approving and will merge once CI passes.

@edelauna edelauna changed the title Update glm Update Z.AI default model to GLM-4.7 May 18, 2026
@edelauna edelauna merged commit ea09844 into Zoo-Code-Org:main May 18, 2026
20 checks passed
@Mirrowel
Copy link
Copy Markdown

Thanks for updating this! Read up on the zAI docs, and it does look like the decision to default to 4.7 is correct - with 5.1 being opt-in.

(Also used this PR as a test ground to see if Roomote could update forked PRs)

Approving and will merge once CI passes.

Nobody really buys z.ai for GLM 4.7, but it doesn't really matter much anyway.
4.7 is outdated

@bryce-hoehn
Copy link
Copy Markdown
Contributor Author

Personally I use GLM 5.1 daily and rarely hit the prompt limit. That said I think the best practice should be token-efficient defaults rather than SOTA models - particularly when the docs have a recommended default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants