[Chore] Unskip VS Code e2e replay for mutating tools#92
Conversation
|
No actionable issues found. See task
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
8cc02ae to
eb95c4e
Compare
|
I see some merge conflicts here. Working on them now... |
|
I see some merge conflicts here. Working on them now... |
49dd725 to
0f30e86
Compare
|
I see some merge conflicts here. Working on them now... |
|
I see some merge conflicts here. Working on them now... |
17bce1c to
26ff2c0
Compare
|
I see some merge conflicts here. Working on them now... |
f491acd to
9fa41b7
Compare
|
Addressed the remaining mutating replay-fixture review item in dafa9c9. The replay helpers now validate representative tool-result payloads for Revalidated |
edelauna
left a comment
There was a problem hiding this comment.
Increasing test coverage
What problem this solves
Fixes an issue where the remaining mutating VS Code e2e tool suites still stayed skipped after the read-only replay work, which left
execute_command,write_to_file, andapply_diffregressions outside the deterministic replay path.Why this change was made
This slice applies the same deterministic replay approach to the mutating tool suites and adds the model/tool-approval configuration those cases need to exercise the real tool path reliably. It now also validates representative mutating tool-result payloads before replay fixtures hand back canned completions, so drift in the tool output itself still fails replay mode.
User impact
No direct product behavior changes. The mutating VS Code e2e tool suites now run under replay and catch more tool-level regressions before release.
Related PRs