Skip to content

[Chore] Unskip VS Code e2e replay for mutating tools#92

Merged
edelauna merged 12 commits into
mainfrom
chore-unskip-e2e-mutating-tools
May 17, 2026
Merged

[Chore] Unskip VS Code e2e replay for mutating tools#92
edelauna merged 12 commits into
mainfrom
chore-unskip-e2e-mutating-tools

Conversation

@roomote
Copy link
Copy Markdown
Contributor

@roomote roomote Bot commented May 13, 2026

Opened on behalf of Elliott de Launay. View the task or mention @roomote for follow-up asks.

What problem this solves

Fixes an issue where the remaining mutating VS Code e2e tool suites still stayed skipped after the read-only replay work, which left execute_command, write_to_file, and apply_diff regressions outside the deterministic replay path.

Why this change was made

This slice applies the same deterministic replay approach to the mutating tool suites and adds the model/tool-approval configuration those cases need to exercise the real tool path reliably. It now also validates representative mutating tool-result payloads before replay fixtures hand back canned completions, so drift in the tool output itself still fails replay mode.

User impact

No direct product behavior changes. The mutating VS Code e2e tool suites now run under replay and catch more tool-level regressions before release.

Related PRs

@roomote roomote Bot added the roomote:auto-resolve-conflicts Allow Roomote to auto-resolve merge conflicts for this PR label May 13, 2026
@roomote
Copy link
Copy Markdown
Contributor Author

roomote Bot commented May 13, 2026

No actionable issues found. See task

  • Wait for TaskCompleted in the write_to_file replay tests so post-write failures still fail the suite.
  • Validate the actual mutating tool result payloads in the replay fixtures instead of matching only on toolCallId.
  • Fix the recursive list_files replay completion text so it mentions nested/deep/; e2e-mock is failing in Roo Code list_files Tool > Should list files in a directory (recursive).
  • Earlier review snapshot: CI completed successfully, including e2e-mock and platform-unit-test (windows-latest).
  • e2e-mock and platform-unit-test (windows-latest) finished successfully after the sync-review wait.
  • compile, e2e-mock, and platform-unit-test (windows-latest) finished successfully after the sync-review wait.
  • Reviewed the read-file.json whitespace-only follow-up in cb244e4; no new issues found.
  • Current CI finished successfully, including compile, e2e-mock, and platform-unit-test (windows-latest).

@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Comment thread apps/vscode-e2e/src/suite/tools/write-to-file.test.ts Outdated
Comment thread apps/vscode-e2e/src/fixtures/apply-diff.ts
@edelauna edelauna force-pushed the chore-unskip-e2e-readonly-tools branch from 8cc02ae to eb95c4e Compare May 16, 2026 12:25
@roomote
Copy link
Copy Markdown
Contributor Author

roomote Bot commented May 16, 2026

I see some merge conflicts here. Working on them now...

@roomote
Copy link
Copy Markdown
Contributor Author

roomote Bot commented May 16, 2026

I see some merge conflicts here. Working on them now...

@edelauna edelauna force-pushed the chore-unskip-e2e-readonly-tools branch from 49dd725 to 0f30e86 Compare May 16, 2026 16:41
@roomote
Copy link
Copy Markdown
Contributor Author

roomote Bot commented May 16, 2026

I see some merge conflicts here. Working on them now...

@roomote
Copy link
Copy Markdown
Contributor Author

roomote Bot commented May 16, 2026

I see some merge conflicts here. Working on them now...

@edelauna edelauna force-pushed the chore-unskip-e2e-readonly-tools branch from 17bce1c to 26ff2c0 Compare May 16, 2026 17:51
Base automatically changed from chore-unskip-e2e-readonly-tools to main May 16, 2026 23:11
@roomote
Copy link
Copy Markdown
Contributor Author

roomote Bot commented May 16, 2026

I see some merge conflicts here. Working on them now...

@edelauna edelauna force-pushed the chore-unskip-e2e-mutating-tools branch from f491acd to 9fa41b7 Compare May 17, 2026 02:53
@edelauna edelauna marked this pull request as ready for review May 17, 2026 03:46
@edelauna edelauna requested a review from taltas as a code owner May 17, 2026 03:46
@roomote
Copy link
Copy Markdown
Contributor Author

roomote Bot commented May 17, 2026

Addressed the remaining mutating replay-fixture review item in dafa9c9. The replay helpers now validate representative tool-result payloads for apply_diff, execute_command, and write_to_file, and the shared matcher logic is centralized in apps/vscode-e2e/src/fixtures/tool-result.ts.

Revalidated apply-diff.test, execute-command.test, write-to-file.test, pnpm --dir apps/web-roo-code test, and http://127.0.0.1:3000 (200 OK). Browser proof is not applicable here because this is fixture/test coverage work rather than a rendered UI change.

Copy link
Copy Markdown
Contributor

@edelauna edelauna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Increasing test coverage

@edelauna edelauna merged commit fd6da8a into main May 17, 2026
9 checks passed
@edelauna edelauna deleted the chore-unskip-e2e-mutating-tools branch May 17, 2026 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

roomote:auto-resolve-conflicts Allow Roomote to auto-resolve merge conflicts for this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants