fix(navbar): allows us to suppress user info in navbar with hotjar #675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #675 +/- ##
=======================================
Coverage 95.48% 95.49%
=======================================
Files 130 130
Lines 1064 1065 +1
Branches 375 376 +1
=======================================
+ Hits 1016 1017 +1
Misses 47 47
Partials 1 1
Continue to review full report at Codecov.
|
MillieClare
requested review from
admmasters,
katebeavis,
moshie,
poteirard,
raff-r and
steedems
as code owners
poteirard
reviewed
Apr 14, 2021
raff-r
reviewed
Apr 14, 2021
admmasters
reviewed
Apr 15, 2021
poteirard
approved these changes
Apr 16, 2021
Contributor
|
🎉 This PR is included in version 4.41.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently HotJar cannot suppress user names in the navbar. This change means we can now add the suppression tag in react-libs to do so and hide all user information in screen recordings.
It's quite clunky, but
aria-labelcan only take a string type, we've added a new propertyaria-labelwhich will be set toundefinedif it receives a label which isn't of type string.