boost beast example#2
Merged
StephanKa merged 8 commits intoZuehlke:mainfrom Apr 27, 2022
Merged
Conversation
wilc-zde
reviewed
Sep 29, 2021
arnemertz
requested changes
Sep 29, 2021
StephanKa
force-pushed
the
feature/add-boost-beast-example
branch
from
b742e50 to
64e52f2
Compare
arnemertz
reviewed
Apr 25, 2022
| namespace beast = boost::beast;// from <boost/beast.hpp> | ||
| namespace http = beast::http;// from <boost/beast/http.hpp> | ||
| namespace asio = boost::asio;// from <boost/asio.hpp> | ||
| using tcp = boost::asio::ip::tcp;// from <boost/asio/ip/tcp.hpp> |
Member
There was a problem hiding this comment.
Do these comments pass the .clang-format check?
arnemertz
reviewed
Apr 25, 2022
| ioc.run(); | ||
|
|
||
| return EXIT_SUCCESS; | ||
| } No newline at end of file |
arnemertz
reviewed
Apr 25, 2022
| return send(std::move(createResponse(req, http::status::internal_server_error, j))); | ||
| } | ||
| } | ||
| } No newline at end of file |
arnemertz
reviewed
Apr 25, 2022
| http::request<http::string_body> m_req; | ||
| std::shared_ptr<void> m_res; | ||
| sendLambda m_lambda; | ||
| }; No newline at end of file |
arnemertz
approved these changes
Apr 25, 2022
Member
arnemertz
left a comment
arnemertz
left a comment
There was a problem hiding this comment.
- Some newlines missing at ends of files (commented)
- Not sure if the formatting passes the clang-format settings we have in place, please check
Otherwise looks good now! 👍🏼
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small example for using boost beast and nlohman/json.
Is this enough for showing how it works or should more to be implemented?