write_videofile() Progress Bar Shows Incorrect Frame Count for Images Over 58

[wym1233]

I'm using write_videofile() to combine multiple images into a video. When the number of images is less than or equal to 58, the progress bar shows the correct number of frames. However, when the number exceeds 58, the progress bar displays one less frame than the actual number. I'm not sure if this is a bug.

Code：

fps = 24
image_files = sorted([os.path.join(image_folder, img) for img in os.listdir(image_folder) if img.endswith(".jpg") or img.endswith(".png")])

image_files=image_files[0:59]
print(len(image_files))
clip = ImageSequenceClip(image_files, fps=fps)
clip.write_videofile(output_video_path, codec='libx264')

#Here the progress bar shows that the number of frames is 58

[MHerveMotimatic]

59 frames at 24 fps means each frame is exactly 0.041666666666666664 seconds in length.
The duration of this video is 2.458333333333333 seconds
The bar logger calculates number of frames for the display as int(self.duration * fps)
and int(2.458333333333333 * 24) = (58.99999999999999)

This is a simple rounding error, and can be solved on line 555 of Clip.py by using a small epsilon for floating point error.

Another option is math.round

frame_index=np.arange(0, int(self.duration * fps + 1e-6))