Fix a typo and add mailto: to the email link#9
Merged
a-chacon merged 2 commits intoa-chacon:mainfrom Aug 25, 2025
Merged
Conversation
Owner
|
@PetitPotiron thank you! I think there are no problems with the forks, they can update it later if needed. Thanks again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Thank you for such a beautiful theme!
In this PR, I made 2 edits:
galley->gallery) in the README (a2d73b1).mailto:to the email address social link in the footer (6b4e2f0) .I am not completely sure if the second (
6b4e2f0) commit is a good idea though. The current problem is, clicking on the link does not lead to any email creation for the_config.ymlsite.rrss.emailbeing configured toemail@example.com(see Mailto on Wikipedia).However, changing such a value would not be backward-compatible as some users (may) have already changed the value of
site.rrss.emailtomailto:email@example.com.Although, as wind is a small theme with not that many users (I assume?), it would not be a major problem. In addition, not a lot of people set this value.
To illustrate, among the 19 forks of this repository, only two did set the
emailvalue:mailto:email@example.com(see here)email@example.comvalue (see here)If we decide to revert the second (
6b4e2f0) commit, we definitely have to change the README or at least the_config.ymlcomments to explain that the blogger has to set-up their email address tomailto:email@example.com. It is not obvious otherwise.