Skip to content

Fix a typo and add mailto: to the email link#9

Merged
a-chacon merged 2 commits intoa-chacon:mainfrom
PetitPotiron:typo
Aug 25, 2025
Merged

Fix a typo and add mailto: to the email link#9
a-chacon merged 2 commits intoa-chacon:mainfrom
PetitPotiron:typo

Conversation

@PetitPotiron
Copy link
Copy Markdown
Contributor

@PetitPotiron PetitPotiron commented Aug 24, 2025

Hello,
Thank you for such a beautiful theme!

In this PR, I made 2 edits:

  1. I corrected typos (galley -> gallery) in the README (a2d73b1).
  2. I added mailto: to the email address social link in the footer (6b4e2f0) .

I am not completely sure if the second (6b4e2f0) commit is a good idea though. The current problem is, clicking on the link does not lead to any email creation for the _config.yml site.rrss.email being configured to email@example.com (see Mailto on Wikipedia).

However, changing such a value would not be backward-compatible as some users (may) have already changed the value of site.rrss.email to mailto:email@example.com.

Although, as wind is a small theme with not that many users (I assume?), it would not be a major problem. In addition, not a lot of people set this value.

To illustrate, among the 19 forks of this repository, only two did set the email value:

  • one did change its value to mailto:email@example.com (see here)
  • the other one sticked to the suggested email@example.com value (see here)

If we decide to revert the second (6b4e2f0) commit, we definitely have to change the README or at least the _config.yml comments to explain that the blogger has to set-up their email address to mailto:email@example.com. It is not obvious otherwise.

@a-chacon
Copy link
Copy Markdown
Owner

@PetitPotiron thank you! I think there are no problems with the forks, they can update it later if needed. Thanks again.

@a-chacon a-chacon merged commit 087bebf into a-chacon:main Aug 25, 2025
@PetitPotiron PetitPotiron deleted the typo branch August 25, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants