Skip to content

Support complex DCQL queries in DC API#538

Merged
nodh merged 3 commits intodevelopfrom
feature/complex_dcql_dcapi
Mar 27, 2026
Merged

Support complex DCQL queries in DC API#538
nodh merged 3 commits intodevelopfrom
feature/complex_dcql_dcapi

Conversation

@gp-iaik
Copy link
Copy Markdown
Collaborator

@gp-iaik gp-iaik commented Mar 19, 2026

No description provided.

@gp-iaik gp-iaik self-assigned this Mar 19, 2026
@chatgpt-codex-connector
Copy link
Copy Markdown

chatgpt-codex-connector bot commented Mar 19, 2026

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@gp-iaik gp-iaik force-pushed the feature/complex_dcql_dcapi branch from b14aeb2 to 62360b5 Compare March 19, 2026 19:55
nodh
nodh reviewed Mar 20, 2026
View reviewed changes
Comment thread openid-data-classes/src/commonMain/kotlin/at/asitplus/dcapi/request/DCAPIWalletRequest.kt Outdated
@gp-iaik gp-iaik force-pushed the feature/complex_dcql_dcapi branch 3 times, most recently from 3e85714 to 5cc6577 Compare March 20, 2026 10:53
@gp-iaik gp-iaik force-pushed the feature/complex_dcql_dcapi branch from 5cc6577 to 742dc18 Compare March 20, 2026 10:56
@gp-iaik gp-iaik requested a review from nodh March 20, 2026 12:36
nodh
nodh requested changes Mar 25, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@nodh nodh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also document the public API changes in Holder in the changelog

Comment thread openid-data-classes/src/commonMain/kotlin/at/asitplus/dcapi/request/DCAPIWalletRequest.kt Outdated
Comment thread ...asses/src/commonTest/kotlin/at/asitplus/dcapi/request/DCAPIWalletRequestSerializationTest.kt Outdated
Comment thread vck-openid-ktor/src/commonTest/kotlin/at/asitplus/wallet/lib/ktor/openid/OpenId4VpWalletTest.kt Outdated
Comment thread vck/src/commonMain/kotlin/at/asitplus/wallet/lib/agent/Holder.kt Outdated
@nodh nodh added this to the 5.12.0 milestone Mar 25, 2026
@nodh
Copy link
Copy Markdown
Member

nodh commented Mar 25, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

chatgpt-codex-connector bot commented Mar 25, 2026

Codex Review: Didn't find any major issues. 👍

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector
Copy link
Copy Markdown

chatgpt-codex-connector bot commented Mar 26, 2026

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@gp-iaik gp-iaik requested a review from nodh March 26, 2026 17:23
@gp-iaik gp-iaik mentioned this pull request Mar 26, 2026
Open
@nodh nodh merged commit 706f237 into develop Mar 27, 2026
5 checks passed
@nodh nodh deleted the feature/complex_dcql_dcapi branch March 27, 2026 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nodh nodh nodh approved these changes

Assignees

@gp-iaik gp-iaik

Labels

None yet

Projects

None yet

Milestone

5.12.0

Development

Successfully merging this pull request may close these issues.

2 participants

@gp-iaik @nodh