refactor response types/structure to match spec#3
Merged
a1denvalu3 merged 4 commits intoa1denvalu3:dlcfrom Aug 26, 2024
Merged
Conversation
The spec now includes the `funding_proof` as a sub-object, which includes a reference to the keyset used to create the funding proof.
Owner
|
Could you please modify the test to reflect the changes you made, as well? |
Author
|
Woops, missed that. Fixed 👍 |
a1denvalu3
approved these changes
Aug 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the code reuses some types (
DlcFundingProof,DlcOutcome) to contain error messages. This is poor hygiene and I wanted to clean it up while also bringing the response structure in line with the latest changes to the spec