Skip to content

Conversation

@tomsun28
Copy link
Contributor

@tomsun28 tomsun28 commented Jun 26, 2025

Description

for issue task #20

  • Follow the CONTRIBUTING Guide.
  • Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
    • Important Prefixes for release-please:
      • fix: which represents bug fixes, and correlates to a SemVer patch.
      • feat: represents a new feature, and correlates to a SemVer minor.
      • feat!:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a SemVer major.
  • Ensure the tests pass
  • Appropriate READMEs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @tomsun28, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces comprehensive unit tests for the A2AClient's sendMessage method, specifically covering scenarios where messages include FilePart and DataPart components. These additions ensure the client correctly handles various message types, improving robustness and verifying expected behavior for rich content.

Highlights

  • New Test Cases for sendMessage: I've added three new test methods (testA2AClientSendMessageWithFilePart, testA2AClientSendMessageWithDataPart, testA2AClientSendMessageWithMixedParts) to A2AClientTest.java to validate the sendMessage functionality when dealing with FilePart and DataPart message components.
  • FilePart Testing: I've included a test case for sending messages with a FilePart, demonstrating usage with FileWithUri and FileWithBytes (in the mixed parts test).
  • DataPart Testing: I've added a dedicated test case for sending messages that contain a DataPart, ensuring proper serialization and handling of arbitrary structured data.
  • Mixed Content Testing: I've introduced a test to verify the sendMessage method's behavior when a message contains both FilePart and DataPart alongside TextPart.
  • Mock JSON Definitions: I've defined new static JSON string constants in JsonMessages.java to serve as mock request and response bodies for the newly added A2AClient tests, facilitating isolated testing.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request effectively introduces new test cases for sending messages with FilePart and DataPart, as well as a combination of both. The new test methods in A2AClientTest.java are well-structured and correctly utilize the mock server to simulate API interactions. The corresponding JSON message constants in JsonMessages.java accurately reflect the expected request and response payloads for these new message part types. The changes are consistent with existing code patterns and enhance the test coverage for the A2A client library. No issues of critical, high, or medium severity were identified.

@tomsun28 tomsun28 changed the title [test] update A2AClientTest with sending FilePart and DataPart test: update A2AClientTest with sending FilePart and DataPart Jun 26, 2025
@maeste maeste merged commit 8538569 into a2aproject:main Jun 26, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants