fix: Change image for the multi instance replicated queuemanager test #439
Conversation
openjdk:17-slim has disappeared
Summary of ChangesHello @kabir, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue where the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request resolves a build failure caused by the disappearance of the openjdk:17-slim Docker image by switching to mirror.gcr.io/eclipse-temurin:17-jre-jammy. The change is correct and addresses the issue. My review includes suggestions to pin the base image to a specific version using an immutable tag. This will improve the stability and reproducibility of your test builds. For future consideration, you might want to centralize the base image definition to avoid duplication across the two Dockerfiles.
| @@ -1,4 +1,4 @@ | |||
| FROM openjdk:17-slim | |||
| FROM mirror.gcr.io/eclipse-temurin:17-jre-jammy | |||
There was a problem hiding this comment.
To ensure reproducible builds, it's a good practice to use a specific, immutable image tag instead of a floating tag like 17-jre-jammy. Floating tags can be updated, potentially introducing unexpected changes or breaking the build. Using a more specific version tag will make your test environment more stable and predictable.
FROM mirror.gcr.io/eclipse-temurin:17.0.11_9-jre-jammy
There was a problem hiding this comment.
Ignoring since we don't really do this in other places
| @@ -1,4 +1,4 @@ | |||
| FROM openjdk:17-slim | |||
| FROM mirror.gcr.io/eclipse-temurin:17-jre-jammy | |||
There was a problem hiding this comment.
To ensure reproducible builds, it's a good practice to use a specific, immutable image tag instead of a floating tag like 17-jre-jammy. Floating tags can be updated, potentially introducing unexpected changes or breaking the build. Using a more specific version tag will make your test environment more stable and predictable.
FROM mirror.gcr.io/eclipse-temurin:17.0.11_9-jre-jammy
There was a problem hiding this comment.
Ignoring since we don't really do this in other places
…a2aproject#439) openjdk:17-slim has disappeared
1 participant
openjdk:17-slim has disappeared