Skip to content

docs: Add skill to fix TCK errors#735

Merged
jmesnil merged 4 commits intoa2aproject:mainfrom
kabir:tck-skill
Mar 13, 2026
Merged

docs: Add skill to fix TCK errors#735
jmesnil merged 4 commits intoa2aproject:mainfrom
kabir:tck-skill

Conversation

@kabir
Copy link
Collaborator

@kabir kabir commented Mar 12, 2026

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new documentation asset that provides a structured approach for engineers to address Transport Compatibility Kit (TCK) errors within the A2A project. It aims to standardize the debugging and resolution process for compatibility issues across different transport layers (HTTP+JSON, gRPC, JSON-RPC), ensuring consistency and thoroughness in fixes.

Highlights

  • New Skill Document Added: A new markdown document, fix-tck-issue.md, was added to the .agents/skills directory. This document outlines a comprehensive workflow for analyzing and fixing A2A Transport Compatibility Kit (TCK) compatibility issues.
  • Standardized TCK Fix Workflow: The new document provides a step-by-step guide covering issue analysis, specification review, code analysis, reproducer creation, fix implementation, verification, and commit procedures for TCK errors across HTTP+JSON, gRPC, and JSON-RPC transports.
  • Emphasis on Reproducers and Verification: The workflow critically emphasizes creating temporary reproducers, confirming their failure before implementing a fix, verifying the fix with these reproducers, and ensuring backward compatibility by running full test suites before committing changes.
Changelog
  • .agents/skills/fix-tck-issue.md
    • Added a new skill document outlining the process for fixing A2A TCK compatibility issues.
Activity
  • A new skill document, fix-tck-issue.md, was added to provide a structured guide for resolving A2A TCK compatibility issues.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new 'skill' documentation file, .agents/skills/fix-tck-issue.md, which provides a detailed workflow for debugging and fixing A2A TCK issues. The document is well-structured and comprehensive. My review includes a couple of suggestions to improve clarity by making some file paths more specific, ensuring the instructions are as unambiguous as possible for developers.

kabir added 3 commits March 12, 2026 14:36
- Add full paths for gRPC and JSON-RPC handlers (Gemini)
- Add optional manual testing step with curl/grpcurl (Jeff)
- Change "handler files" to "impacted files" for broader applicability (Jeff)
- Remove Co-Authored-By line from skill documentation (Jeff)
- Simplify transport/* structure to simple list (Gemini)
- Clarify a2a.proto and spec are source of truth, not TCK (Jeff)
- Improve wording: "code changes" instead of "handler changes" (Jeff)

Addresses feedback from PR a2aproject#735 reviews.
@jmesnil jmesnil merged commit ab77fd0 into a2aproject:main Mar 13, 2026
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants