docs: Add skill to fix TCK errors#735
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new documentation asset that provides a structured approach for engineers to address Transport Compatibility Kit (TCK) errors within the A2A project. It aims to standardize the debugging and resolution process for compatibility issues across different transport layers (HTTP+JSON, gRPC, JSON-RPC), ensuring consistency and thoroughness in fixes. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds a new 'skill' documentation file, .agents/skills/fix-tck-issue.md, which provides a detailed workflow for debugging and fixing A2A TCK issues. The document is well-structured and comprehensive. My review includes a couple of suggestions to improve clarity by making some file paths more specific, ensuring the instructions are as unambiguous as possible for developers.
- Add full paths for gRPC and JSON-RPC handlers (Gemini) - Add optional manual testing step with curl/grpcurl (Jeff) - Change "handler files" to "impacted files" for broader applicability (Jeff) - Remove Co-Authored-By line from skill documentation (Jeff) - Simplify transport/* structure to simple list (Gemini) - Clarify a2a.proto and spec are source of truth, not TCK (Jeff) - Improve wording: "code changes" instead of "handler changes" (Jeff) Addresses feedback from PR a2aproject#735 reviews.
No description provided.