chore: updating the workflows#796
Merged
kabir merged 5 commits intoa2aproject:0.3.x-compatfrom Apr 20, 2026
Merged
Conversation
Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
Extract request id before jsonrpc validation so error responses include top-level id. Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
kabir
approved these changes
Apr 20, 2026
Collaborator
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Kafka version in Kubernetes deployments and improves the deployment script's robustness by waiting for the PostgreSQL pod creation. In the Java codebase, it enhances JSON-RPC 2.0 compliance by ensuring the "result" field is explicitly included in success responses (even when null) via a new TypeAdapterFactory. Additionally, it introduces structured validation logic across several request classes with new check() methods and expands Javadoc documentation for various specification records. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.