fix: Include Authorization header in push notification webhook requests#814
Merged
ehsavoie merged 2 commits intoa2aproject:mainfrom Apr 28, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the BasePushNotificationSender to support authentication in push notifications by adding an Authorization header when credentials are provided. The review feedback suggests refining the header construction to prevent malformed values when the authentication scheme or credentials are null or blank, correcting a minor indentation error, and adopting lowercase header names for better HTTP/2 compatibility.
When PushNotificationConfig includes authentication info, the agent must
include the Authorization header in webhook requests per A2A spec
section 4.3.3 (PUSH-DELIVER-001). The header is formatted as
"{scheme} {credentials}" from the AuthenticationInfo record.
This fixes a2aproject#810
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jmesnil
force-pushed
the
810_push_notification_authorization
branch
from
0ce1d18 to
54a8ad7
Compare
Contributor
Author
|
|
ehsavoie
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When PushNotificationConfig includes authentication info, the agent must include the Authorization header in webhook requests per A2A spec section 4.3.3 (PUSH-DELIVER-001). The header is formatted as "{scheme} {credentials}" from the AuthenticationInfo record.
This fixes #810