feat: add url and preferredTransport fields to AgentCard for v0.3 compatibility#863
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces backward compatibility for v0.3 clients by adding "url" and "preferredTransport" fields to the AgentCard model and updating the JSON parser to optionally ignore unknown fields. The changes include new test cases for parsing v1.0 agent cards. Review feedback highlights that the new fields are currently ignored in the AgentCardMapper, which may hinder their use. Additionally, there is a potential compilation error in the AgentCard builder due to a missing enum reference, and inconsistent field access in the copy constructor should be addressed for better readability.
…patibility Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
kabir
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #<issue_number_goes_here> 🦕