Skip to content

feat: add url and preferredTransport fields to AgentCard for v0.3 compatibility#863

Merged
ehsavoie merged 1 commit into
a2aproject:mainfrom
ehsavoie:agent_card
May 13, 2026
Merged

feat: add url and preferredTransport fields to AgentCard for v0.3 compatibility#863
ehsavoie merged 1 commit into
a2aproject:mainfrom
ehsavoie:agent_card

Conversation

@ehsavoie
Copy link
Copy Markdown
Collaborator

Fixes #<issue_number_goes_here> 🦕

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces backward compatibility for v0.3 clients by adding "url" and "preferredTransport" fields to the AgentCard model and updating the JSON parser to optionally ignore unknown fields. The changes include new test cases for parsing v1.0 agent cards. Review feedback highlights that the new fields are currently ignored in the AgentCardMapper, which may hinder their use. Additionally, there is a potential compilation error in the AgentCard builder due to a missing enum reference, and inconsistent field access in the copy constructor should be addressed for better readability.

Comment thread spec/src/main/java/org/a2aproject/sdk/spec/AgentCard.java Outdated
Comment thread spec/src/main/java/org/a2aproject/sdk/spec/AgentCard.java Outdated
@ehsavoie ehsavoie added the hold label May 12, 2026
…patibility

Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
@ehsavoie ehsavoie removed the hold label May 13, 2026
@ehsavoie ehsavoie merged commit b586145 into a2aproject:main May 13, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants