-
Notifications
You must be signed in to change notification settings - Fork 317
feat(spec): Update A2A types from specification 🤖 #347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(spec): Update A2A types from specification 🤖 #347
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @a2a-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request synchronizes the Python A2A data types with the latest external specification. The changes primarily focus on refining the AgentInterface and AgentCard models, enhancing their robustness through explicit field definitions and providing comprehensive documentation to guide implementers on transport protocol handling and URL configurations.
Highlights
- Enhanced Data Model Definitions: Updated
AgentInterfaceandAgentCardmodels to leverage Pydantic'sFieldfor improved validation, default values, and example data, aligning with the latest A2A specification. - Standardized Transport Protocols: Introduced a new
TransportProtocolEnum to provide explicit, type-safe definitions for supported A2A communication protocols (JSONRPC, GRPC, HTTP+JSON). - Improved Documentation and Guidance: Expanded docstrings across several fields, including
AgentInterface.transport,AgentInterface.url,AgentCard.additional_interfaces,AgentCard.preferred_transport, andAgentCard.url, to offer clearer explanations, best practices, and crucial constraints for A2A agent implementations and client interactions.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the A2A Pydantic models in src/a2a/types.py to align with the latest specification. The changes add more detail and examples to the models. The TransportProtocol enum should be used consistently for transport-related fields to improve type safety and maintainability.
| """ | ||
|
|
||
| transport: str | ||
| transport: str = Field(..., examples=['JSONRPC', 'GRPC', 'HTTP+JSON']) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using the TransportProtocol enum here for the transport field instead of str. This provides better type safety and validation.
| transport: str = Field(..., examples=['JSONRPC', 'GRPC', 'HTTP+JSON']) | |
| transport: TransportProtocol = Field(..., examples=[TransportProtocol.jsonrpc, TransportProtocol.grpc, TransportProtocol.http_json]) |
| preferred_transport: str | None = Field( | ||
| default='JSONRPC', examples=['JSONRPC', 'GRPC', 'HTTP+JSON'] | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The preferred_transport field should use the TransportProtocol enum for type safety and consistency. The default value should also be updated to use the enum member.
| preferred_transport: str | None = Field( | |
| default='JSONRPC', examples=['JSONRPC', 'GRPC', 'HTTP+JSON'] | |
| ) | |
| preferred_transport: TransportProtocol | None = Field( | |
| default=TransportProtocol.jsonrpc, examples=[TransportProtocol.jsonrpc, TransportProtocol.grpc, TransportProtocol.http_json] | |
| ) |
This PR updates
src/a2a/types.pybased on the latestspecification/json/a2a.jsonfrom a2aproject/A2A.BEGIN_COMMIT_OVERRIDE
fix(spec): Add Transport enum to specification (a2aproject/A2A#909)
Adds Enum of supported Transports to Specification, with extensibility
for proprietary protocols.
Adds URL formatting requirement for
AgentInterface.urlandAgentCard.urlEND_COMMIT_OVERRIDE